8000 Test x86 and x86-64 architectures on appveyor by maiksensi · Pull Request #567 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test x86 and x86-64 architectures on appveyor #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2015
Merged

Test x86 and x86-64 architectures on appveyor #567

merged 1 commit into from
Nov 5, 2015

Conversation

maiksensi
Copy link
Contributor

This PR will make sure cookiecutter is tested against x86 and x86-64 architecture interpreters on appveyor. The idea was to catch problems if a dependency fails to install on either architecture, like #557.

This only changes testing on appveyor, as I am not sure whether this is possible on travis-ci without installing the corresponding interpreter from source and without changing tox.ini.
Maybe someone has some insight on this, I am not sure I can have a look at it anytime soon.

Does this make sense, or is it better to leave the current testing as it is, to make sure testing is identical on both buildservers?

Should documentation be updated?

@codecov-io
Copy link

Current coverage is 99.18%

Merging #567 into master will not affect coverage as of cfa5dc1

@@            master    #567   diff @@
======================================
  Files           12      12       
  Stmts          489     489       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            485     485       
  Partial          0       0       
  Missed           4       4

Review entire Coverage Diff as of cfa5dc1

Uncovered Suggestions

  1. +0.41% via ...okiecutter/config.py#19...20
  2. +0.41% via ...ookiecutter/utils.py#27...28

Powered by Codecov. Updated on successful CI builds.

@hackebrot
Copy link
Member

LGTM 👍

@hackebrot hackebrot added the developers This issue/PR has request to other project developers label Oct 26, 2015
pydanny added a commit that referenced this pull request Nov 5, 2015
@pydanny
Merge pull request #567 from maiksensi/feat/test-all-platforms-on-app…
b39374c 
…veyor

Test x86 and x86-64 architectures on appveyor
@pydanny pydanny merged commit b39374c into cookiecutter:master Nov 5, 2015
@maiksensi maiksensi deleted the feat/test-all-platforms-on-appveyor branch November 9, 2015 08:05
@hackebrot hackebrot mentioned this pull request Dec 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
developers This issue/PR has request to other project developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maiksensi @codecov-io @hackebrot @pydanny
0