8000 chore: Update hasCopyAddressOnClick by cpcramer · Pull Request #1547 · coinbase/onchainkit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Update hasCopyAddressOnClick #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2024
Merged

chore: Update hasCopyAddressOnClick #1547

merged 3 commits into from
Nov 1, 2024

Conversation

cpcramer
Copy link
Contributor

What changed? Why?

Notes to reviewers

How has it been tested?

@github-actions github-actions bot added documentation Improvements or additions to documentation pkg: identity pkg: wallet labels Oct 30, 2024
@cpcramer cpcramer changed the title Fix chore: Update hasCopyAddressOnClick Oct 30, 2024
@vercel Vercel
Copy link
vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 4:08pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 4:08pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 4:08pm

cpcramer
cpcramer commented Oct 31, 2024
View reviewed changes
cpcramer
cpcramer commented Oct 31, 2024
View reviewed changes
site/docs/pages/swap/types.mdx
@@ -139,7 +139,9 @@ type SwapQuote = {
type SwapReact = {
children: ReactNode;
className?: string; // Optional className override for top div element.
config?: SwapConfig;
config?: {
maxSlippage: number; // Maximum acceptable slippage for a swap (e.g., 3 for 3%). This is a percentage, not basis points;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged from a user that we had no documentation of the maxSlippage param. SwapConfig is not an exported type and this page does not support twoslash

alessey
alessey reviewed Nov 1, 2024
View reviewed changes
@cpcramer cpcramer force-pushed the paul/test-copyOnClick-address branch from f3522e8 to 791d04f Compare November 1, 2024 15:30
alessey
alessey reviewed Nov 1, 2024
View reviewed changes
@0xAlec 0xAlec merged commit 2f79c49 into main Nov 1, 2024
16 checks passed
@0xAlec 0xAlec deleted the paul/test-copyOnClick-address branch November 1, 2024 16:12
This was referenced Nov 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessey alessey alessey approved these changes

@dschlabach dschlabach dschlabach approved these changes

@0xAlec 0xAlec 0xAlec approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation pkg: identity pkg: wallet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpcramer @alessey @dschlabach @0xAlec
0