Refactor v2_1 messages #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 93.99% 96.36% +2.36%
==========================================
Files 189 271 +82
Lines 31464 58584 +27120
==========================================
+ Hits 29576 56457 +26881
- Misses 1888 2127 +239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hello @AnlangA, thanks! Not sure why codecov is failing. Will have to check that first. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors v2_1 messages by updating multiple enumeration definitions to include enhanced documentation and unified serialization behavior.
- Added documentation and serde attributes across enumeration variants for consistency.
- Added new enumeration variants and modules to support additional message types.
Reviewed Changes
Copilot reviewed 113 out of 113 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/v2_1/enumerations/vpn.rs | Added documentation and applied camelCase renaming for VPN protocol variants. |
| src/v2_1/enumerations/upload_log_status.rs | Updated to include default variant and camelCase renaming for upload status. |
| src/v2_1/enumerations/update_firmware_status.rs | Added new firmware update status variants with clear documentation. |
| src/v2_1/enumerations/update.rs | Refined update types with descriptive documentation and serialization formatting. |
| src/v2_1/enumerations/unpublish_firmware_status.rs | Improved documentation and serialization for unpublishing firmware status. |
| src/v2_1/enumerations/unlock_status.rs | Enhanced documentation and standardized enum variant naming for unlock status. |
| src/v2_1/enumerations/trigger_reason.rs | Extended trigger reason enum with detailed variant descriptions. |
| src/v2_1/enumerations/transaction_event.rs | Updated transaction event types with additional documentation and renaming. |
| src/v2_1/enumerations/tariff_cost.rs | Applied camelCase renaming and added documentation for tariff cost variants. |
| src/v2_1/enumerations/tariff_clear_status.rs | Enhanced documentation with camelCase renaming for tariff clear status. |
| src/v2_1/enumerations/tariff_change_status.rs | Updated tariff change status with consistent serialization formatting. |
| src/v2_1/enumerations/set_variable_status.rs | Improved documentation and variant naming for set variable status. |
| src/v2_1/enumerations/set_network_profile_status.rs | Added descriptive comments and camelCase renaming for network profile status. |
| src/v2_1/enumerations/set_monitoring_status.rs | Refined monitoring status enum with updated documentation and renaming. |
| src/v2_1/enumerations/send_local_list_status.rs | Extended local list status enum with clear documentation and valid serialization. |
| src/v2_1/enumerations/reset_status.rs | Updated reset status without Default derivation, differing from most enumerations. |
| src/v2_1/enumerations/reset.rs | Added new reset type variant and improved documentation with serialization attributes. |
| src/v2_1/enumerations/reservation_update_status.rs | Standardized reservation update status with camelCase renaming and clear docs. |
| src/v2_1/enumerations/mod.rs | Updated module exports to include new enumerations, maintaining consistent naming. |
| src/v2_1/enumerations/data_enum.rs | Minor reordering of serde import, aligning with updated style in other files. |
Comments suppressed due to low confidence (1)
src/v2_1/enumerations/reset_status.rs:4
- [nitpick] Consider deriving Default for ResetStatusEnumType for consistency with other enumerations, unless the omission is intentional.
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
- Introduced PeriodicEventStreamParamsType to encapsulate parameters for the periodic event stream. - Added nested validation for custom_data and params fields in AdjustPeriodicEventStreamRequest. - Removed redundant PeriodicEventStreamParamsType struct definition from the file to streamline the code.
- Reorder imports alphabetically for consistency - Split long use statements into multiple lines for better readability - Standardize import formatting across all message modules - Update mod.rs with improved multi-line use statements This change improves code maintainability and follows Rust formatting conventions.
…d HeartbeatResponse
… and AFRRSignalResponse
…ertificateSignedResponse
… display message, variable monitoring, and cost updated messages
… and ReserveNowResponse
Tests cover serialization, validation, builder patterns, setter methods, and all enum variants for both TriggerMessageRequest and TriggerMessageResponse structs.
Extends test coverage for authorize, clear_charging_profile, clear_display_message, clear_variable_monitoring, and cost_updated message types with setter method validation, method chaining verification, optional field clearing, edge case handling, and partial JSON deserialization tests.
Tests cover builder pattern usage, method chaining with other fields, and setter/getter methods including clearing tariff values.
a68bd0b to
211399d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the messages in v2_1, corrected some errors in it, including encoding format and numerical limits, etc. I also added functions