8000 Re design table schema and foreign keys between `Softwares` and `SoftwareExternalDatas` · Issue #298 · codegouvfr/sill · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re design table schema and foreign keys between Softwares and SoftwareExternalDatas #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guillermau opened this issue Feb 18, 2025 · 1 comment · Fixed by #361
Closed

Re design table schema and foreign keys between Softwares and SoftwareExternalDatas #298

guillermau opened this issue Feb 18, 2025 · 1 comment · Fixed by #361
Assignees
@guillermau
Labels
enhancement New feature or request genericity to discuss Issue to discuss
Milestone
Multi Source

Comments

@guillermau
Copy link
Collaborator
guillermau commented Feb 18, 2025 •
edited
Loading

There is no structured link between Softwares and SoftwareExternalDatas.

Proposal :

  • Add foreign keys softwareId key from Softwares on SoftwareExternalDatas.
  • Add field externalDataOriginType to save which connecter to use for example GitLab
  • Migrate externalDataOrigin from string to URL of the endpoint to retrieve data

Old proposal

ExternalData table

  • On rajoute le champ softwareId clefs étrangère vers l'index de la tablesoftwares
  • On migre externalId en sourceSoftwareId
  • On migre externalDataOrigin en sourceId clef étrangère vers l'index de la table source

Table source

  • Création d'une table source avec id:number, nom:string, type:<TpeSource>, url:string et primacy:boolean
  • Les sources types seront : HAL, SWH, Wikidata, GitHub, ComptoirDuLibre, GitLab ou encore Zenodo.
@guillermau guillermau added enhancement New feature or request genericity to discuss Issue to discuss labels Feb 18, 2025
@guillermau guillermau mentioned this issue Feb 18, 2025
Open
@guillermau
Copy link
Collaborator Author
guillermau commented Feb 19, 2025 •
edited
Loading

Proposal

{
  "softwareId": 12,
  "externalId": "starpu/starpu",
  "externalDataOriginType": "GitLab",
  "externalDataOrigin": "https://gitlab.inria.fr/"
}

For a same software :

{
  "softwareId": 11,
  "externalId": "Q91312803",
  "externalDataOriginType": "WikiData",
  "externalDataOrigin": "https://www.wikidata.org"
}
{
  "softwareId": 11,
  "externalId": "380",
  "externalDataOriginType": "ComptoirDuLibre",
  "externalDataOrigin": "https://comptoir-du-libre.org/"
}

@guillermau guillermau self-assigned this Feb 20, 2025
guillermau added a commit that referenced this issue Feb 26, 2025
@guillermau
#298 : Change on referencedSinceTime
e503460
guillermau added a commit that referenced this issue Feb 26, 2025
@guillermau
#298 : Change on referencedSinceTime
448b4d4
guillermau added a commit that referenced this issue Feb 26, 2025
@guillermau
#298 : add isReferenced
3f135f2
guillermau added a commit that referenced this issue Feb 26, 2025
@guillermau
#298 : change similar table to softwareId
cd842c2
@guillermau guillermau added this to the Multi Source milestone Mar 7, 2025
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : Change on referencedSinceTime
f0b5dae
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : add isReferenced
3fb6dc5 
# Conflicts:
#    api/scripts/migration/software.ts
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : Keep isReferenced out out of the database
018edbd
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : implement similar software
77c65d3
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : Fix getAll and getByIdWithLinkedSoftwaresIds
adb76a1
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : Fix test
ec1dff3
guillermau added a commit that referenced this issue Mar 13, 2025
@guillermau
#298 : fix name
cd5ef4b
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Change on referencedSinceTime
e88f3b1
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : add isReferenced
6ed797f 
# Conflicts:
#    api/scripts/migration/software.ts
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Keep isReferenced out out of the database
3f34df1
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : implement similar software
b5658d9
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Fix getAll and getByIdWithLinkedSoftwaresIds
1da9748
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Fix test
ca22213
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : fix name
7e385d9
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Change on referencedSinceTime
bd794ef
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : add isReferenced
f1d04ff 
# Conflicts:
#    api/scripts/migration/software.ts
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Keep isReferenced out out of the database
8000
1ccc3fd
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : implement similar software
7d74b7c
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Fix getAll and getByIdWithLinkedSoftwaresIds
7a77539
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : Fix test
01102af
JeromeBu pushed a commit that referenced this issue Mar 14, 2025
@guillermau @JeromeBu
#298 : fix name
8ee9f67
@guillermau guillermau linked a pull request May 14, 2025 that will close this issue
Make usecases "create", "import" and "update" compatible with multi sources #361
Merged
@guillermau guillermau mentioned this issue May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillermau guillermau

Labels
enhancement New feature or request genericity to discuss Issue to discuss
Projects
None yet
Milestone
Multi Source
Development

Successfully merging a pull request may close this issue.

Make usecases "create", "import" and "update" compatible with multi sources codegouvfr/sill
1 participant
@guillermau
0