fix: test analytics chain prev result handling #968
Conversation
i previously forgot that chains pass through a single previous result through all the tasks so this commit fixes that we pass a boolean that at first is false, if at any point there is a single parsing success then it becomes true and means there was at least one success in parsing a test results file the finisher then replaces the call to check_if_no_success with checking if the previous result is false
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/test_results_finisher.py
📄 File: tasks/test_results_processor.py (Click to Expand)
📄 File: tasks/upload.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 97.98% 97.97% -0.01%
==========================================
Files 443 443
Lines 35821 35823 +2
==========================================
+ Hits 35098 35099 +1
- Misses 723 724 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
i previously forgot that chains pass through a single previous result through all the tasks so this commit fixes that
we pass a boolean that at first is false, if at any point there is a single parsing success then it becomes true and means there was at least one success in parsing a test results file
the finisher then replaces the call to check_if_no_success with checking if the previous result is false