10000 fix: don't cache rollups if branch none by joseph-sentry · Pull Request #943 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: don't cache rollups if branch none #943

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: don't cache rollups if branch none #943

merged 1 commit into from
Dec 5, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team December 4, 2024 21:40
@codecov-notifications
Copy link
codecov-notifications bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov Codecov
Copy link
codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (a723522) to head (55b8d01).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         445      445           
  Lines       35754    35755    +1     
=======================================
+ Hits        35034    35035    +1     
  Misses        720      720
Flag Coverage Δ
integration 42.11% <100.00%> (+<0.01%) ⬆️
unit 90.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 4, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem
Copy link
Contributor
Swatinem commented Dec 5, 2024

The change makes sense, I just wonder how this can happen in reality? Under which circumstances will there be no branch at all B39B ?

@joseph-sentry
Copy link
Contributor Author

The change makes sense, I just wonder how this can happen in reality? Under which circumstances will there be no branch at all?

it's possible that it's something about not being able to fetch the branch from the github api

@joseph-sentry joseph-sentry added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 8f48629 Dec 5, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-cache-test-rollups branch December 5, 2024 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @Swatinem
0