8000 build: upload test results first by joseph-sentry · Pull Request #949 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

build: upload test results first #949

Merged
merged 1 commit into from
Dec 9, 2024
Merged

build: upload test results first #949

merged 1 commit into from
Dec 9, 2024

Conversation

joseph-sentry
Copy link
Contributor

this is so if there are failures and issues with uploading coverage at least the PR comment for test results will be accurate.

It makes sense for all users to upload their test results first, then their coverage

@joseph-sentry
build: upload test results first
bb91c02 
this is so if there are failures and issues with uploading coverage
at least the PR comment for test results will be accurate.

It makes sense for all users to upload their test results first, then
their coverage
@joseph-sentry joseph-sentry requested a review from a team December 6, 2024 14:55
@joseph-sentry joseph-sentry marked this pull request as ready for review December 6, 2024 14:55
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 6, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov Codecov
Copy link
codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (96bed1f) to head (bb91c02).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         445      445           
  Lines       35754    35750    -4     
=======================================
- Hits        35036    35034    -2     
+ Misses        718      716    -2
Flag Coverage Δ
integration 42.12% <ø> (+<0.01%) ⬆️
unit 90.63% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giovanni-guidini
Copy link
Contributor

It makes sense for all users to upload their test results first, then their coverage

I totally agree. Also if it's a requirement in our system we should at least make it clear in the docs (in case it's not already there, probably is) to avoid customers with the same issues as we have

@joseph-sentry joseph-sentry added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit e22c04e Dec 9, 2024
25 checks passed
@joseph-sentry joseph-sentry deleted the joseph/upload-test-results-first branch December 9, 2024 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @giovanni-guidini
0