8000 add Account model to worker's sqlalchemy models representations by nora-shap · Pull Request #930 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

add Account model to worker's sqlalchemy models representations #930

Merged
merged 10 commits into from 8000
Dec 4, 2024

Conversation

nora-shap
Copy link
Member

I think this is blocking the shared release, which I need in order to complete the monthly self-hosted release
This is how I would add the Account model - lmk what you think!

@nora-shap nora-shap requested a review from RulaKhaled December 2, 2024 21:59
@codecov-notifications
Copy link
codecov-notifications bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
github-actions bot commented Dec 2, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (3c883aa) to head (3819643).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   97.97%   97.98%   +0.01%     
==========================================
  Files         446      446              
  Lines       35666    35730      +64     
==========================================
+ Hits        34942    35010      +68     
+ Misses        724      720       -4     
Flag Coverage Δ
integration 42.05% <38.80%> (-0.02%) ⬇️
unit 90.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

users = relationship(
"User", secondary="codecov_auth_accountsusers", back_populates="accounts"
)
organizations = relationship("Owner", back_populates="account")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have orgs in account do we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is how you represent a many-to-many in sqlalchemy, from these docs. You have to explicitly set the related_name field, so it looks different from django but is the same thing

Copy link
Contributor
@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a quick comment

@RulaKhaled RulaKhaled mentioned this pull request Dec 3, 2024
1 task
@nora-shap nora-shap changed the base branch from update-shared-v to main December 3, 2024 17:40
Copy link
github-actions bot commented Dec 3, 2024

This PR includes changes to shared. Please review them here: codecov/shared@c481846...5fb0c83

@RulaKhaled RulaKhaled enabled auto-merge December 4, 2024 10:50
@RulaKhaled RulaKhaled added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 3e52df5 Dec 4, 2024
26 of 27 checks passed
@RulaKhaled RulaKhaled deleted the add-account-model-to-worker branch December 4, 2024 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0