-
Notifications
You must be signed in to change notification settings - Fork 11
add Account model to worker's sqlalchemy models representations #930
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 97.97% 97.98% +0.01%
==========================================
Files 446 446
Lines 35666 35730 +64
==========================================
+ Hits 34942 35010 +68
+ Misses 724 720 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
users = relationship( | ||
"User", secondary="codecov_auth_accountsusers", back_populates="accounts" | ||
) | ||
organizations = relationship("Owner", back_populates="account") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have orgs in account do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is how you represent a many-to-many in sqlalchemy, from these docs. You have to explicitly set the related_name
field, so it looks different from django but is the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left a quick comment
This PR includes changes to |
I think this is blocking the shared release, which I need in order to complete the monthly self-hosted release
This is how I would add the Account model - lmk what you think!