Resolve test flags in python #898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 97.98% 90.73% -7.25%
==========================================
Files 446 446
Lines 35602 35629 +27
==========================================
- Hits 34884 32328 -2556
- Misses 718 3301 +2583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 97.96% 90.74% -7.23%
==========================================
Files 446 444 -2
Lines 35626 35444 -182
==========================================
- Hits 34901 32162 -2739
- Misses 725 3282 +2557
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
966d192 to
d4c5933
Compare
5271138 to
b373611
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 97.96% 90.74% -7.23%
==========================================
Files 446 444 -2
Lines 35626 35444 -182
==========================================
- Hits 34901 32162 -2739
- Misses 725 3282 +2557
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ba93349 to
268fb1b
Compare
The test flags subquery seems to be very slow, so instead of resolving test names via SQL, we do the resolution in python by just returning the `flag_id`, and looking up the name using a dict.
268fb1b to
bce0d87
Compare
✅ Sentry found no issues in your recent changes ✅ |
The test flags subquery seems to be very slow, so instead of resolving test names via SQL, we do the resolution in python by just returning the
flag_id, and looking up the name using a dict.