8000 fix: cache tasks args by joseph-sentry · Pull Request #871 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: cache tasks args #871

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: cache tasks args #871

merged 1 commit into from
Nov 8, 2024

Conversation

joseph-sentry
Copy link
Contributor
@joseph-sentry joseph-sentry commented Nov 8, 2024 •
edited
Loading

this fixes an error where the cache tasks only expect one arg instead of all the actual args

@joseph-sentry joseph-sentry requested a review from a team November 8, 2024 20:05
@codecov Codecov
Copy link
codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (dbd2417) to head (9bd8f07).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 94.73% <100.00%> (ø)
tasks/cache_test_rollups_redis.py 93.54% <100.00%> (ø)

@codecov-notifications
Copy link
codecov-notifications bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 94.73% <100.00%> (ø)
tasks/cache_test_rollups_redis.py 93.54% <100.00%> (ø)

@codecov-qa
Copy link
codecov-qa bot commented Nov 8, 2024 •
edited
Loading 8000

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (dbd2417) to head (9bd8f07).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 94.73% <100.00%> (ø)
tasks/cache_test_rollups_redis.py 93.54% <100.00%> (ø)

@codecov-public-qa Codecov Public QA
Copy link
codecov-public-qa bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (dbd2417) to head (9bd8f07).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files Coverage Δ
tasks/cache_test_rollups.py 94.73% <100.00%> (ø)
tasks/cache_test_rollups_redis.py 93.54% <100.00%> (ø)

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 8, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 68da17c Nov 8, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-cache-tasks branch November 8, 2024 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michelletran-codecov michelletran-codecov michelletran-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @michelletran-codecov
0