8000 fix: minimize deadlocks by joseph-sentry · Pull Request #869 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: minimize deadlocks #869

Merged
merged 3 commits into from
Nov 8, 2024
8000
Merged

fix: minimize deadlocks #869

merged 3 commits into from
Nov 8, 2024

Conversation

joseph-sentry
Copy link
Contributor
@joseph-sentry joseph-sentry commented Nov 8, 2024 •
edited
Loading

@codecov Codecov
Copy link
codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (dbd2417) to head (8a28032).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.15% <100.00%> (ø)
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link
codecov-notifications bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.15% <100.00%> (ø)
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link
codecov-qa bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (dbd2417) to head (8a28032).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.15% <100.00%> (ø)
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-public-qa Codecov Public QA
Copy link
codecov-public-qa bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (dbd2417) to head (8a28032).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         444      444           
  Lines       35463    35463           
=======================================
  Hits        34731    34731           
  Misses        732      732
Flag Coverage Δ
integration 41.99% <100.00%> (ø)
unit 90.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (ø)
OutsideTasks 95.63% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 97.15% <100.00%> (ø)
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 8, 2024 •
edited
Loading

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry requested a review from a team November 8, 2024 16:20
adrian-codecov
adrian-codecov reviewed Nov 8, 2024
View reviewed changes
tasks/test_results_processor.py Outdated
sorted(test_data.values(), key=lambda x: str(x["flags_hash"]))
sorted(
test_data.values(),
key=lambda x: str(x["test_id"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting 3 errors w/ this change, this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my latest change should fix those

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 6844106 Nov 8, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-deadlocks branch November 8, 2024 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @adrian-codecov
0