This repository was archived by the owner on May 5, 2025. It is now read-only.
Make process_raw_upload return the Report directly
#850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 98.02% 97.98% -0.05%
==========================================
Files 444 444
Lines 36057 35942 -115
==========================================
- Hits 35346 35216 -130
- Misses 711 726 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 98.02% 97.98% -0.05%
==========================================
Files 444 444
Lines 36057 35942 -115
==========================================
- Hits 35346 35216 -130
- Misses 711 726 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 98.02% 97.98% -0.05%
==========================================
Files 444 444
Lines 36057 35942 -115
==========================================
- Hits 35346 35216 -130
- Misses 711 726 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 98.02% 97.98% -0.05%
==========================================
Files 444 444
Lines 36057 35942 -115
==========================================
- Hits 35346 35216 -130
- Misses 711 726 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b935dfb to
0e50655
Compare
The `process_raw_upload` function would previously get a partial `report` as one of its arguments, to merge the processed upload into. As this has changed fundamentally with parallel upload processing, we can just return the processed `Report` directly.
0e50655 to
c7729d8
Compare
giovanni-guidini
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process_raw_uploadfunction would previously get a partialreportas one of its arguments, to merge the processed upload into.As this has changed fundamentally with parallel upload processing, we can just return the processed
Reportdirectly.