This repository was archived by the owner on May 5, 2025. It is now read-only.
Stop writing ReportDetails/files_array
#840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 443 444 +1
Lines 36054 35984 -70
==========================================
- Hits 35350 35279 -71
- Misses 704 705 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 443 444 +1
Lines 36054 35984 -70
==========================================
- Hits 35350 35279 -71
- Misses 704 705 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 443 444 +1
Lines 36054 35984 -70
==========================================
- Hits 35350 35279 -71
- Misses 704 705 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 443 444 +1
Lines 36054 35984 -70
==========================================
- Hits 35350 35279 -71
- Misses 704 705 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1a56669 to
b4cdea8
Compare
This model was previously used for the ill-fated `report_builder` feature which was since removed. Avoiding the table and in particular the `files_array` saves us from one GCS write per report, so should speed up the `UploadFinisher` ever so slightly.
b4cdea8 to
93a28a8
Compare
michelletran-codecov
approved these changes
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This model was previously used for the ill-fated
report_builderfeature which was since removed.Avoiding the table and in particular the
files_arraysaves us from one GCS write per report, so should speed up theUploadFinisherever so slightly.