This repository was archived by the owner on May 5, 2025. It is now read-only.
Hardcode parallel mode in UploadFinisher
#825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
+ Coverage 97.84% 98.02% +0.17%
==========================================
Files 444 442 -2
Lines 36345 36163 -182
==========================================
- Hits 35561 35448 -113
+ Misses 784 715 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #825 +/- ##
==========================================
+ Coverage 97.84% 98.02% +0.17%
==========================================
Files 444 442 -2
Lines 36345 36163 -182
==========================================
- Hits 35561 35448 -113
+ Misses 784 715 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #825 +/- ##
==========================================
+ Coverage 97.84% 98.02% +0.17%
==========================================
Files 444 442 -2
Lines 36345 36163 -182
==========================================
- Hits 35561 35448 -113
+ Misses 784 715 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #825 +/- ##
==========================================
+ Coverage 97.84% 98.02% +0.17%
==========================================
Files 444 442 -2
Lines 36345 36163 -182
==========================================
- Hits 35561 35448 -113
+ Misses 784 715 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dbe478c to
27a7afe
Compare
af7cceb to
f521af3
Compare
This removes all the non-parallel code from `UploadFinisher`, and consolidates some other code as well which now became obsolete. In particular, this removes the parallel feature flag, and the parallel verification task.
f521af3 to
2d25a26
Compare
giovanni-guidini
approved these changes
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the non-parallel code from
UploadFinisher, and consolidates some other code as well which now became obsolete.In particular, this removes the parallel feature flag, and the parallel verification task.