This repository was archived by the owner on May 5, 2025. It is now read-only.
Optimize update_uploads
#783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was doing a SELECT/UPDATE cycle for each of the `Upload` records needing updates. This will now avoid doing the SELECTs, and only emit `UPDATE` statements. As a driveby change, this should also fix an edge-case where a deleted `session_id` is immediately being reused.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36602 36601 -1
==========================================
- Hits 35883 35882 -1
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36602 36601 -1
==========================================
- Hits 35883 35882 -1
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36602 36601 -1
==========================================
- Hits 35883 35882 -1
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36602 36601 -1
==========================================
- Hits 35883 35882 -1
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was doing a SELECT/UPDATE cycle for each of the
Uploadrecords needing updates. This will now avoid doing the SELECTs, and only emitUPDATEstatements.As a driveby change, this should also fix an edge-case where a deleted
session_idis immediately being reused.