8000 Simplify `get_installation_name` a bit by Swatinem · Pull Request #751 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Simplify get_installation_name a bit #751

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Simplify get_installation_name a bit #751

merged 1 commit into from
Oct 1, 2024

Conversation

Swatinem
Copy link
Contributor

This is the same as #749 which I reverted immediately as the added caching for get_repo_provider_service did not work properly due to the types not being pickle-able.

@Swatinem Swatinem requested a review from a team September 30, 2024 15:33
@Swatinem Swatinem self-assigned this Sep 30, 2024
@codecov Codecov
Copy link
codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (e43cf58) to head (c9ff86d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   98.08%   98.08%   -0.01%     
==========================================
  Files         432      432              
  Lines       36292    36290       -2     
==========================================
- Hits        35598    35594       -4     
- Misses        694      696       +2
Flag Coverage Δ
integration 98.08% <100.00%> (-0.01%) ⬇️
unit 98.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.99% <100.00%> (-0.02%) ⬇️
OutsideTasks 98.13% <100.00%> (ø)
Files with missing lines Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (ø)
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.18% <100.00%> (-0.78%) ⬇️
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

@codecov-notifications
Copy link
codecov-notifications bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   98.08%   98.08%   -0.01%     
==========================================
  Files         432      432              
  Lines       36292    36290       -2     
==========================================
- Hits        35598    35594       -4     
- Misses        694      696       +2
Flag Coverage Δ
integration 98.08% <100.00%> (-0.01%) ⬇️
unit 98.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.99% <100.00%> (-0.02%) ⬇️
OutsideTasks 98.13% <100.00%> (ø)
Files with missing lines Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (ø)
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.18% <100.00%> (-0.78%) ⬇️
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

8000

@codecov-public-qa Codecov Public QA
Copy link
codecov-public-qa bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (e43cf58) to head (c9ff86d).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   98.08%   98.08%   -0.01%     
==========================================
  Files         432      432              
  Lines       36292    36290       -2     
==========================================
- Hits        35598    35594       -4     
- Misses        694      696       +2
Flag Coverage Δ
integration 98.08% <100.00%> (-0.01%) ⬇️
unit 98.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.99% <100.00%> (-0.02%) ⬇️
OutsideTasks 98.13% <100.00%> (ø)
Files Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (ø)
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.18% <100.00%> (-0.78%) ⬇️
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

@codecov-qa
Copy link
codecov-qa bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e43cf58). Learn more about missing BASE report.
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage        ?   98.08%           
=======================================
  Files           ?      432           
  Lines           ?    36290           
  Branches        ?        0           
=======================================
  Hits            ?    35594           
  Misses          ?      696           
  Partials        ?        0
Flag Coverage Δ
integration 98.08% <100.00%> (?)
unit 98.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.99% <100.00%> (?)
OutsideTasks 98.13% <100.00%> (?)
Files with missing lines Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (ø)
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.18% <100.00%> (ø)
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

@Swatinem Swatinem added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 6779039 Oct 1, 2024
35 of 40 checks passed
@Swatinem Swatinem deleted the swatinem/simple-installation branch October 1, 2024 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @giovanni-guidini
0