10000 Revert "Simplifies `get_installation_name` a bit (#749)" by Swatinem · Pull Request #750 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Revert "Simplifies get_installation_name a bit (#749)" #750

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Revert "Simplifies get_installation_name a bit (#749)" #750

merged 1 commit into from
Sep 30, 2024

Conversation

Swatinem
Copy link
Contributor

This reverts commit 7607091.

@Swatinem Swatinem self-assigned this Sep 30, 2024
@Swatinem Swatinem enabled auto-merge September 30, 2024 15:18
@codecov-notifications
Copy link
codecov-notifications bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         432      432           
  Lines       36292    36292           
=======================================
+ Hits        35596    35598    +2     
+ Misses        696      694    -2
Flag Coverage Δ
integration 98.08% <100.00%> (+<0.01%) ⬆️
unit 98.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.13% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (-0.03%) ⬇️
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.95% <100.00%> (+0.77%) ⬆️
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

@codecov Codecov
Copy link
codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (7607091) to head (2800213).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         432      432           
  Lines       36292    36292           
=======================================
+ Hits        35596    35598    +2     
+ Misses        696      694    -2
Flag Coverage Δ
integration 98.08% <100.00%> (+<0.01%) ⬆️
unit 98.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.13% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (-0.03%) ⬇️
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.95% <100.00%> (+0.77%) ⬆️
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

@Swatinem Swatinem added this pull request to the merge queue Sep 30, 2024
@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (7607091) to head (2800213).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         432      432           
  Lines       36292    36292           
=======================================
+ Hits        35596    35598    +2     
+ Misses        696      694    -2
Flag Coverage Δ
integration 98.08% <100.00%> (+<0.01%) ⬆️
unit 98.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.13% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
helpers/github_installation.py 100.00% <100.00%> (ø)
helpers/tests/unit/test_github_installation.py 100.00% <100.00%> (ø)
services/repository.py 96.76% <100.00%> (-0.03%) ⬇️
services/tests/test_repository_service.py 99.78% <ø> (ø)
tasks/bundle_analysis_notify.py 95.00% <ø> (ø)
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 100.00% <ø> (ø)
tasks/notify.py 95.95% <100.00%> (+0.77%) ⬆️
tasks/preprocess_upload.py 98.14% <ø> (ø)
tasks/save_report_results.py 98.79% <ø> (ø)
... and 4 more

Merged via the queue into main with commit e43cf58 Sep 30, 2024
24 of 25 checks passed
@Swatinem Swatinem deleted the swatinem/revert-ghcache branch September 30, 2024 15:28
@sentry-io Sentry.io
Copy link
sentry-io bot commented Sep 30, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: cannot pickle '_thread.lock' object app.tasks.pulls.Sync View Issue
  • ‼️ TypeError: cannot pickle '_thread.lock' object app.tasks.notify.Notify View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @giovanni-guidini
0