8000 feat: disable annotations by default by joseph-sentry · Pull Request #717 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

feat: disable annotations by default #717

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat: disable annotations by default #717

merged 1 commit into from
Sep 18, 2024

Conversation

joseph-sentry
Copy link
Contributor
@joseph-sentry joseph-sentry commented Sep 17, 2024 •
edited
Loading

@joseph-sentry joseph-sentry requested a review from a team September 17, 2024 20:17
@codecov-notifications
Copy link
codecov-notifications bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   97.92%   98.07%   +0.14%     
==========================================
  Files         434      434              
  Lines       36733    36734       +1     
==========================================
+ Hits        35971    36027      +56     
+ Misses        762      707      -55
Flag Coverage Δ
integration 98.07% <ø> (+0.14%) ⬆️
latest-uploader-overall 98.07% <ø> (+0.14%) ⬆️
unit 98.07% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
services/notification/notifiers/checks/patch.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@codecov-qa
Copy link
codecov-qa bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (fa0e247) to head (f051313).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   97.92%   98.07%   +0.14%     
==========================================
  Files         434      434              
  Lines       36733    36734       +1     
==========================================
+ Hits        35971    36027      +56     
+ Misses        762      707      -55
Flag Coverage Δ
integration 98.07% <ø> (+0.14%) ⬆️
latest-uploader-overall 98.07% <ø> (+0.14%) ⬆️
unit 98.07% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
services/notification/notifiers/checks/patch.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@codecov-public-qa Codecov Public QA
Copy link
codecov-public-qa bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (fa0e247) to head (f051313).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   97.92%   98.07%   +0.14%     
==========================================
  Files         434      434              
  Lines       36733    36734       +1     
==========================================
+ Hits        35971    36027      +56     
+ Misses        762      707      -55
Flag Coverage Δ
integration 98.07% <ø> (+0.14%) ⬆️
latest-uploader-overall 98.07% <ø> (+0.14%) ⬆️
unit 98.07% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
services/notification/notifiers/checks/patch.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@codecov Codecov
Copy link
codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (fa0e247) to head (f051313).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   97.97%   98.12%   +0.14%     
==========================================
  Files         475      475              
  Lines       38088    38089       +1     
==========================================
+ Hits        37318    37374      +56     
+ Misses        770      715      -55
Flag Coverage Δ
integration 98.07% <ø> (+0.14%) ⬆️
latest-uploader-overall 98.07% <ø> (+0.14%) ⬆️
unit 98.07% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.08% <ø> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
services/notification/notifiers/checks/patch.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 6ecd3ba Sep 18, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/disable-annotations branch September 18, 2024 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Annotations do not clear once sent.
2 participants
@joseph-sentry @Swatinem
0