This repository was archived by the owner on May 5, 2025. It is now read-only.
Update shared again, removing change_sessionid
#1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes changes to |
b0a22a5 to
fa901c9
Compare
|
This is currently blocked on codecov/shared#539 and codecov/shared#540 |
233d18f to
d422eef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
=======================================
Coverage 97.25% 97.26%
=======================================
Files 454 454
Lines 37447 37425 -22
=======================================
- Hits 36418 36400 -18
+ Misses 1029 1025 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
giovanni-guidini
approved these changes
Feb 27, 2025
| shared = { git = "https://github.com/codecov/shared", rev = "fd58134d9f15bce28917f68bda9e740dd9fe32ff" } |
There was a problem hiding this comment.
so nice to see the uv stuff. way better
This function has been moved to `shared`, so can now be removed from `worker`.
d422eef to
42c6213
Compare
Closed
JerrySentry
added a commit
that referenced
this pull request
Mar 12, 2025
🚨 Sentry detected 6 potential issues in your recent changes 🚨
Lower risk findings
|
JerrySentry
added a commit
that referenced
this pull request
Mar 18, 2025
✅ Sentry found no issues in your recent changes ✅ |
JerrySentry
added a commit
that referenced
this pull request
Mar 19, 2025
JerrySentry
added a commit
that referenced
this pull request
Mar 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has been moved to
shared, so can now be removed fromworker.