DEV: revise release action to address python 3.13.4 bug #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHANGED] pinned to 3.13.3. Also now just test the lowest
and highest supported python versions.
Reviewer's GuideRefactor the release workflow by pinning Python to 3.13.3 and limiting tests to the lowest and highest supported versions, while migrating environment setup and test execution to the uv tool for improved caching and consistency. Sequence Diagram for Updated CI Build Job StepssequenceDiagram;
participant Runner as GitHub Actions Runner;
participant Checkout as actions/checkout;
participant SetupPython as actions/setup-python;
participant SetupUV as astral-sh/setup-uv;
participant UV as uv CLI;
participant Nox as nox CLI;
Runner ->> Checkout: Execute (fetch code);
Checkout -->> Runner: Code available;
Runner ->> SetupPython: Execute (setup Python from matrix: 3.10, 3.13.3);
SetupPython -->> Runner: Specific Python version ready;
Runner ->> SetupUV: Execute (install uv, enable cache based on pyproject.toml);
SetupUV -->> Runner: uv CLI available;
Runner ->> UV: Create venv (uv venv venv -p python${{ matrix.python-version }});
UV -->> Runner: Virtual environment 'venv' created;
Runner ->> UV: Install nox (uv tool install -p venv nox);
UV -->> Runner: nox installed in 'venv';
Runner ->> Nox: Run tests (nox -db uv --force-python python -s test);
Nox -->> Runner: Test results;
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @GavinHuttley - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/release.yml:37` </location>
<code_context>
+ - name: "Run nox for ${{ matrix.python-version }}"
+ shell: bash
+ run: |
+ nox -db uv --force-python python -s test
- - name: "Run nox for Python ${{ matrix.python-version }}"
</code_context>
<issue_to_address>
The `-db uv` flag likely misgroups options
Use `nox -d uv --force-python python -s test` to avoid misinterpreting `-db uv` as `-d b`. This ensures the correct driver is specified.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - name: "Run nox for ${{ matrix.python-version }}" | ||
| shell: bash | ||
| run: | | ||
| nox -db uv --force-python python -s test |
There was a problem hiding this comment.
issue (bug_risk): The -db uv flag likely misgroups options
Use nox -d uv --force-python python -s test to avoid misinterpreting -db uv as -d b. This ensures the correct driver is specified.
Pull Request Test Coverage Report for Build 15645889132Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CHANGED] pinned to 3.13.3. Also now just test the lowest
and highest supported python versions.
Summary by Sourcery
Revise the release workflow to address Python 3.13.4 by pinning supported versions and adopting UV-managed environment and test steps.
CI: