8000 utils: Thread - Fix that thread logs don't end after it completed by SchoolGuy · Pull Request #3264 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

utils: Thread - Fix that thread logs don't end after it completed #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

utils: Thread - Fix that thread logs don't end after it completed #3264

merged 1 commit into from
Oct 17, 2022

Conversation

SchoolGuy
Copy link
Member

Linked Items

Fixes #3263

Description

This was due to the fact that the handler wasn't removed from the root logger.

Behaviour changes

Old:

New:

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy
utils: Thread - Fix that thread logs don't end after it completed
ff4c882 
This was due to the fact that the handler wasn't removed from the root logger.
@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Oct 14, 2022
@SchoolGuy SchoolGuy requested a review from a team October 14, 2022 14:23
vzhestkov
vzhestkov approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SchoolGuy SchoolGuy merged commit 2a1af2c into main Oct 17, 2022
@SchoolGuy SchoolGuy deleted the fix/thread_logger branch October 17, 2022 08:48
@SchoolGuy SchoolGuy mentioned this pull request Jun 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhestkov vzhestkov vzhestkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Task logs don't end
2 participants
@SchoolGuy @vzhestkov
0