"cobbler buildiso": Prevent image based systems from being processed #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was not clear that the command was only able to work with systems that are profile based. This is now mentioned at two prominent locations. Systems that are image based will be filtered out.
The test will now consider that image based systems should not appear in the list of systems.
agraul
approved these changes
Aug 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #3237 +/- ##
==========================================
+ Coverage 65.26% 65.42% +0.15%
==========================================
Files 110 110
Lines 14937 14942 +5
==========================================
+ Hits 9749 9776 +27
+ Misses 5188 5166 -22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Items
Fixes #3236
Description
See title
Behaviour changes
Old:
cobbler buildiso --systemsprocesses image based systemsNew:
cobbler buildiso --systemsdoesn't process image based systemsCategory
This is related to a:
Tests