8000 Fix `cobbler buildiso --exclude-dns` by SchoolGuy · Pull Request #3210 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix cobbler buildiso --exclude-dns #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2022
Merged

Fix cobbler buildiso --exclude-dns #3210

merged 5 commits into from
Jul 26, 2022

Conversation

SchoolGuy
Copy link
Member

Fixes #2995

For explanations please look at the individual commit messages.

SchoolGuy added 3 commits July 25, 2022 13:00
@SchoolGuy
Tests: Reuse "cobbler_api" fixture
e8eb37a
@SchoolGuy
Docs: Buildiso - Clarify usage of --exclude-dns parameter
afa535d
@SchoolGuy
Actions: Buildiso - Fix DNS append line generation
7bd43ba 
This commit also cleans up the raw usage of the distro class in favor of the
API fixtures provided by conftest.py in the root test folder.
@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Jul 25, 2022
@SchoolGuy SchoolGuy requested a review from a team July 25, 2022 11:37
@github-actions github-actions bot added documentation Improvements or additions to documentation tests labels Jul 25, 2022
@SchoolGuy SchoolGuy force-pushed the fix/buildiso-exclude-dns branch 2 times, most recently from 7dea096 to b1ead77 Compare July 25, 2022 12:38
@SchoolGuy SchoolGuy force-pushed the fix/buildiso-exclude-dns branch from b1ead77 to dbf904b Compare July 25, 2022 13:02
@codecov
Copy link
codecov bot commented Jul 25, 2022

Codecov Report

Merging #3210 (dbf904b) into main (07717b9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
+ Coverage   63.84%   63.86%   +0.01%     
==========================================
  Files         109      109              
  Lines       14657    14657              
==========================================
+ Hits         9358     9360       +2     
+ Misses       5299     5297       -2
Impacted Files Coverage Δ
cobbler/actions/buildiso/netboot.py 44.03% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07717b9...dbf904b. Read the comment docs.

tiltingpenguin
tiltingpenguin reviewed Jul 26, 2022
View reviewed changes
vzhestkov
vzhestkov approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SchoolGuy SchoolGuy mentioned this pull request Jul 26, 2022
Open
@SchoolGuy SchoolGuy requested a review from tiltingpenguin July 26, 2022 10:45
tiltingpenguin
tiltingpenguin approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor
@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns were adressed, LGTM now

@SchoolGuy SchoolGuy merged commit 56996f0 into main Jul 26, 2022
@SchoolGuy SchoolGuy deleted the fix/buildiso-exclude-dns branch July 26, 2022 10:50
@SchoolGuy SchoolGuy mentioned this pull request Jul 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhestkov vzhestkov vzhestkov approved these changes

@tiltingpenguin tiltingpenguin tiltingpenguin approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Buildiso: --exclude-dns has no effect
3 participants
@SchoolGuy @vzhestkov @tiltingpenguin
0