XML-RPC API: Fix complex objects are return value #3172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug is appearing in "get_item_resolved_value" and could be triggered for example when "arch" was asked with a distro. The fix is to catch all types in "remote.py" and convert them on a per-type basis. This commit also adds tests for the known cases that would cause trouble in the past.
3 tasks
meaksh
approved these changes
Jul 7, 2022
This bug is appearing in "get_item_resolved_value" and could be triggered for example when "arch" was asked with a distro. The fix is to catch all types in "remote.py" and convert them on a per-type basis. This commit also adds tests for the known cases that would cause trouble in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is appearing in "get_item_resolved_value" and could be triggered for
example when "arch" was asked with a distro. The fix is to catch all types in
"remote.py" and convert them on a per-type basis.
This commit also adds tests for the known cases that would cause trouble in the
past.