Backports for Uyuni/SUMA #3124
Merged
Backports for Uyuni/SUMA #3124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the Python Class inheritance it is not needed to redefine the method and duplicate the code that checks for the existence of the name since the base already implements that check.
Co-authored-by: Alexander Graul <agraul@suse.com>
This commit also moves the tests to a dedicated file as these test have nothing to do with a Cobbler system.
It was not possible to search for all fields on a network interface before. The reason was a not updated field list for the network interface.
This also adds a custom decorator which enables the code to check if the property at hand is inheritable or not. Conflicts: cobbler/api.py
Executing the system-tests in the same environment as the unit-tests ensures that we can reuse the already built container. Co-authored-by: Nico Krapp <nico.krapp@suse.com>
migration validation now uses the old validation method for the old settings
It contained the faulty "proxies" key which we introduced in 3.3.3
The reason we increase the numbers is that the "include" key is present in 3.3.3 and on main it is not anymore.
Codecov Report
@@ Coverage Diff @@
## release33 #3124 +/- ##
=============================================
+ Coverage 61.88% 62.47% +0.58%
=============================================
Files 101 103 +2
Lines 14407 14528 +121
=============================================
+ Hits 8916 9076 +160
+ Misses 5491 5452 -39
Continue to review full report at Codecov.
|
vzhestkov
approved these changes
Jun 2, 2022
This was referenced Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These backports are hopefully the last ones I need. The issues for the backport requests I will open tomorrow. Tests are still failing, so this has to be investigated as well...