8000 Fix - Owners inheritance by SchoolGuy · Pull Request #3119 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix - Owners inheritance #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 27, 2022
Merged

Fix - Owners inheritance #3119

merged 7 commits into from
May 27, 2022

Conversation

SchoolGuy
Copy link
Member

Fixes #3118

The branch in this PR was initially mainly thought for adding the dump_vars endpoint to the XML-RPC API but the bug which was found during testing caused a shift in this.

Nevertheless the new endpoint is in this branch along with:

  • the bugfix mentioned in the issue and PR title
  • the fact that the owners field no inherits per default from the settings instead of copying the settings into its object

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone May 27, 2022
@SchoolGuy SchoolGuy requested a review from a team May 27, 2022 13:31
@github-actions github-actions bot added the tests label May 27, 2022
vzhestkov
vzhestkov reviewed May 27, 2022
View reviewed changes
vzhestkov
vzhestkov reviewed May 27, 2022
View reviewed changes
vzhestkov
vzhestkov reviewed May 27, 2022
View reviewed changes
@codecov
Copy link
codecov bot commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #3119 (a67decc) into main (2d9353d) will increase coverage by 0.10%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
+ Coverage   62.39%   62.49%   +0.10%     
==========================================
  Files         102      102              
  Lines       14483    14491       +8     
==========================================
+ Hits         9036     9056      +20     
+ Misses       5447     5435      -12
Impacted Files Coverage Δ
cobbler/remote.py 58.46% <20.00%> (-0.15%) ⬇️
cobbler/api.py 63.07% <50.00%> (ø)
cobbler/items/item.py 87.03% <100.00%> (+0.55%) ⬆️
cobbler/utils.py 70.91% <100.00%> (-0.18%) ⬇️
cobbler/autoinstallgen.py 11.86% <0.00%> (+0.56%) ⬆️
cobbler/cobbler_collections/collection.py 75.55% <0.00%> (+0.88%) ⬆️
cobbler/items/profile.py 94.84% <0.00%> (+1.21%) ⬆️
cobbler/autoinstall_manager.py 72.22% <0.00%> (+4.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9353d...a67decc. Read the comment docs.

vzhestkov
vzhestkov approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpicky siggestion in the code, but in general looks good for me 👍

@SchoolGuy SchoolGuy force-pushed the fix/owners-inheritance branch from 9c8c8e1 to a67decc Compare May 27, 2022 14:36
@SchoolGuy SchoolGuy merged commit 132aefa into main May 27, 2022
@SchoolGuy SchoolGuy deleted the fix/owners-inheritance branch May 27, 2022 14:58
@SchoolGuy SchoolGuy mentioned this pull request Jun 3, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhestkov vzhestkov vzhestkov approved these changes

Assignees
No one assigned
Labels
tests
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

utils.blender is dropping fields
2 participants
@SchoolGuy @vzhestkov
0