8000 Backports/virt file size float by SchoolGuy · Pull Request #3073 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backports/virt file size float #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2022
Merged

Backports/virt file size float #3073

merged 8 commits into from
Apr 25, 2022

Conversation

SchoolGuy
Copy link
Member

Fixes #3072

@SchoolGuy
virt_file_size: Use float in all places
8050d83 
Before there was a mix of int and float. This mix was now converted to float in
all places which is: Docs, Tests, Settings, CLI.
@SchoolGuy
Increase version to 3.3.3
387c04c
@SchoolGuy
Add migration for 3.3.3
4581f53
@SchoolGuy
Add test data for 3.3.2
87fb61f
@SchoolGuy
CI: Update workflows to run against correct branches
743c35b
@SchoolGuy SchoolGuy added this to the V3.3.3 milestone Apr 22, 2022
@SchoolGuy
Copy link
Member Author

Does not work atm sadly...

@SchoolGuy SchoolGuy force-pushed the backports/virt_file_size_float branch 2 times, most recently from af2f489 to e6fefc7 Compare April 25, 2022 08:22
@SchoolGuy SchoolGuy force-pushed the backports/virt_file_size_float branch from e6fefc7 to 861bb51 Compare April 25, 2022 08:23
@SchoolGuy SchoolGuy marked this pull request as ready for review April 25, 2022 08:26
@SchoolGuy SchoolGuy requested a review from a team April 25, 2022 08:26
@SchoolGuy
Copy link
Member Author

The Tumbleweed problems are persisting but locally it runs fine now.

agraul
agraul approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor
@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a small question, looks good overall.

meaksh
meaksh approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member
@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me as well. I also wonder about the 2 leading spaces.

@SchoolGuy SchoolGuy linked an issue Apr 25, 2022 that may be closed by this pull request
[Backport] virt_file_size: Use float in all places #3072
Closed
3 tasks
@SchoolGuy SchoolGuy mentioned this pull request Apr 25, 2022
Open
@SchoolGuy
Copy link
Member Author

The failing tests are related to an error in the LDAP dependency tree we are using. Locally with openSUSE Leap they pass. Thus I will merge this PR now. Thanks to the reviewers!

@SchoolGuy SchoolGuy merged commit b4df371 into release33 Apr 25, 2022
@SchoolGuy SchoolGuy deleted the backports/virt_file_size_float branch April 25, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meaksh meaksh meaksh approved these changes

@agraul agraul agraul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Cobbler Server
Status: Done
Milestone
V3.3.3
Development

Successfully merging this pull request may close these issues.

[Backport] virt_file_size: Use float in all places
3 participants
@SchoolGuy @meaksh @agraul
0