8000 setup.py: Fix logger by SchoolGuy · Pull Request #3037 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

setup.py: Fix logger #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

setup.py: Fix logger #3037

merged 1 commit into from
Apr 19, 2022

Conversation

SchoolGuy
Copy link
Member

Fixes #3035

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Apr 18, 2022
@SchoolGuy SchoolGuy requested a review from a team April 18, 2022 19:48
vzhestkov
vzhestkov approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SchoolGuy SchoolGuy force-pushed the fix/setup-py-logging branch from 379d3b5 to 04ef9d4 Compare April 19, 2022 06:17
@SchoolGuy
setup.py: Fix logger
0a35cbe 
Before we haven't seen the output of the custom log messages we created. This
was due to the fact that we have not attached us to the logger already present
from setuptools/distutils.
@SchoolGuy SchoolGuy force-pushed the fix/setup-py-logging branch from 04ef9d4 to 0a35cbe Compare April 19, 2022 06:22
@SchoolGuy
Copy link
Member Author

Sigh... A SEGFAULT from the LDAP tests again. This is definitely not related to this change. Let's ignore this for now.

@SchoolGuy SchoolGuy merged commit be15d32 into main Apr 19, 2022
@SchoolGuy SchoolGuy deleted the fix/setup-py-logging branch April 19, 2022 06:34
@SchoolGuy SchoolGuy mentioned this pull request Apr 19, 2022
Closed
3 tasks
agraul
agraul reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor
@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agraul
Copy link
Contributor
agraul commented Apr 21, 2022

Whoops, I wanted to review the backport 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agraul agraul agraul left review comments

@vzhestkov vzhestkov vzhestkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Logging in setup.py
3 participants
@SchoolGuy @agraul @vzhestkov
0