Prevent crash during Cobbler startup on NFS environments #3906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to wait until #3814 is merged to fix the CI. |
|
I also need to bring some changelog here. I'll add it shortly |
This was referenced May 12, 2025
|
@meaksh Could you please rebase the PR? I merged the transaction PR with the CI changes. |
SchoolGuy
reviewed
May 13, 2025
Since Linux 2.6.12, NFS clients support flock() locks by emulating them as fcntl(2) byte-range locks on the entire file. This means that fcntl(2) and flock() locks do interact with one another over NFS. It also means that in order to place an exclusive lock, the file must be opened for writing. https://man7.org/linux/man-pages/man2/flock.2.html
54c0779 to
1c832a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
flockmechanism used by Cobbler serializer is not working on NFS enviroments, leading to a crash during Cobbler startup.This PR fixes the
flockmechanism to work in NFS environments on Linux kernel >= 2.6.12.Linked Items
Fixes #3905
Description
As mentioned at https://man7.org/linux/man-pages/man2/flock.2.html:
Since Linux 2.6.12, NFS clients support flock() locks by emulating them as fcntl(2) byte-range locks on the entire file. This means that fcntl(2) and flock() locks do interact with one another over NFS. It also means that in order to place an exclusive lock, the file must be opened for writing.
Behaviour changes
Old: cobbler is not able to start.
New: cobbler starts successfully.
Category
This is related to a:
Tests