8000 Feature: Dedicated network interfaces by SchoolGuy · Pull Request #3882 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature: Dedicated network interfaces #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Feature: Dedicated network interfaces #3882

wants to merge 3 commits into from

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented Jan 30, 2025 •
edited
Loading

Linked Items

Split-out of #3440

Description

This PR does two things:

  • Remove the old CLI
  • Introduce a new dedicated collection for network interfaces

Behaviour changes

Old: The bundled CLI and embedded network interfaces limited the maintainability of the code.

New: Clear separation between backend and consuming clients.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Jan 30, 2025
@SchoolGuy SchoolGuy force-pushed the feature/dedicated-networkinterfaces branch from 9e46083 to d6a1509 Compare January 30, 2025 09:45
@github-actions github-actions bot added documentation Improvements or additions to documentation API tests labels Jan 30, 2025
@SchoolGuy SchoolGuy force-pushed the feature/dedicated-networkinterfaces branch from d6a1509 to 7a4750f Compare January 30, 2025 09:48
@codacy-production Codacy Production
Copy link
codacy-production bot commented Jan 30, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.22% (target: -1.00%) ✅ ∅ (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7b63d12) 16106 10910 67.74%
Head commit (bb3e279) 15434 (-672) 10488 (-422) 67.95% (+0.22%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3882) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@SchoolGuy SchoolGuy force-pushed the feature/dedicated-networkinterfaces branch from 7a4750f to 7450dea Compare January 30, 2025 11:53
@github-actions github-actions bot added the CI CI/CD related label Jan 30, 2025
@SchoolGuy SchoolGuy mentioned this pull request Jan 30, 2025
Merged
12 tasks
@SchoolGuy SchoolGuy force-pushed the feature/dedicated-networkinterfaces branch 2 times, most recently from 3423d17 to 286612c Compare January 30, 2025 13:14
@github-actions github-actions bot removed the CI CI/CD related label Jan 30, 2025
@SchoolGuy SchoolGuy mentioned this pull request Jan 30, 2025
Draft
12 tasks
@SchoolGuy SchoolGuy added the no changelog This doesn't need a changelog label Apr 13, 2025
@SchoolGuy SchoolGuy force-pushed 8000 the feature/dedicated-networkinterfaces branch from 286612c to 95d687d Compare April 13, 2025 08:22
@github-actions github-actions bot added the CI CI/CD related label Apr 13, 2025
@SchoolGuy SchoolGuy force-pushed the feature/dedicated-networkinterfaces branch from ef57b99 to f64c213 Compare May 22, 2025 07:28
@github-actions github-actions bot removed the CI CI/CD related label May 22, 2025
SchoolGuy and others added 3 commits May 22, 2025 13:42
@SchoolGuy
CLI: Remove bundled CLI
e9f9bbc
@SchoolGuy
XML-RPC: Remove xapi_edit
ca4a303 
This was only used by the old CLI. This all-in-one edit method was too ugly.
@SchoolGuy
Docs: Remove CLI manpages
6590e63
@SchoolGuy SchoolGuy force-pushed the feature/dedicated-networkinterfaces branch from f64c213 to 6590e63 Compare May 22, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API documentation Improvements or additions to documentation no changelog This doesn't need a changelog tests
Projects
Cobbler Server
Status: Pull Requests
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchoolGuy
0