8000 Actions: Buildiso - Fix DNS append line generation by SchoolGuy · Pull Request #3755 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Actions: Buildiso - Fix DNS append line generation #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

SchoolGuy
Copy link
Member

Linked Items

Fixes #3747

Description

cobbler buildiso: Fix DNS append line generation

This commit also cleans up the raw usage of the distro class in favor of the API fixtures provided by conftest.py in the root test folder.

Behaviour changes

Old: The flag --exclude-dns had no effect

New: The flags for cobbler buildiso are now working as expected.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added the backport Backported changes and features. label Jul 8, 2024
@SchoolGuy SchoolGuy added this to the v3.3.6 milestone Jul 8, 2024
@SchoolGuy SchoolGuy requested a review from a team July 8, 2024 08:48
@SchoolGuy SchoolGuy force-pushed the backport/fix-buildiso-dns branch from a51d019 to 9a668ec Compare July 8, 2024 08:49
Copy link
Contributor
@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you first fix the test failures please?

@SchoolGuy SchoolGuy requested a review from m-czernek July 8, 2024 13:51
@SchoolGuy SchoolGuy force-pushed the backport/fix-buildiso-dns branch 2 times, most recently from 7783b9c to f9e7e23 Compare July 8, 2024 13:52
Copy link
Contributor
@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (provided the tests pass :) ), works as expected

This commit also cleans up the raw usage of the distro class in favor of the
API fixtures provided by conftest.py in the root test folder.
@SchoolGuy SchoolGuy force-pushed the backport/fix-buildiso-dns branch from f9e7e23 to cac8771 Compare July 8, 2024 15:10
@SchoolGuy SchoolGuy merged commit 973f955 into release33 Jul 9, 2024
16 checks passed
@SchoolGuy SchoolGuy deleted the backport/fix-buildiso-dns branch July 9, 2024 06:54
@SchoolGuy SchoolGuy linked an issue Jul 9, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backported changes and features.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Backport] Buildiso: --exclude-dns has no effect
2 participants
0