8000 [Backport] Modules: scm_track - Fix pushing to repositories by SchoolGuy · Pull Request #3622 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Backport] Modules: scm_track - Fix pushing to repositories #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented Feb 23, 2024

Linked Items

Fixes #3621

Description

Cobbler crashed when enabling scm_track. Especially the scm_track_push_script setting didn't work due to a subprocess.call refactoring.

Behaviour changes

Old: Cobbler crashes when using scm_track

New: Cobbler is able to push to remote repositories with the scm_track module.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by 8000 System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.3.4 milestone Feb 23, 2024
@SchoolGuy SchoolGuy requested a review from a team February 23, 2024 14:43
@SchoolGuy SchoolGuy force-pushed the backport/scm-push-fix branch from f856ef3 to 0577500 Compare February 23, 2024 14:47
@SchoolGuy SchoolGuy added the backport Backported changes and features. label Feb 23, 2024
@SchoolGuy SchoolGuy changed the title Modules: scm_track - Fix pushing to repositories [Backport] Modules: scm_track - Fix pushing to repositories Feb 23, 2024
@SchoolGuy SchoolGuy linked an issue Feb 23, 2024 that may be closed by this pull request
3 tasks
@SchoolGuy SchoolGuy merged commit 700eb5b into release33 Feb 23, 2024
@SchoolGuy SchoolGuy deleted the backport/scm-push-fix branch February 23, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backported changes and features.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Backport] scm_track: Push script not working
2 participants
0