8000 Backport: Fixup smaller Docs issues by SchoolGuy · Pull Request #3617 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport: Fixup smaller Docs issues #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 23, 2024
Merged

Backport: Fixup smaller Docs issues #3617

merged 6 commits into from
Feb 23, 2024

Conversation

SchoolGuy
Copy link
Member

Linked Items

Fixes #3612

Description

The documentation for the DHCP & DNS topics were not extensive enough and contained dead links. This PR addresses this in addition to smaller fixes for the settings.yaml documentation.

Behaviour changes

Old: Documentation for DHCP & DNS was not functional

New: Documentation for DHCP & DNS have an improved state.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added documentation Improvements or additions to documentation backport Backported changes and features. labels Feb 23, 2024
@SchoolGuy SchoolGuy added this to the v3.3.4 milestone Feb 23, 2024
@SchoolGuy SchoolGuy requested a review from a team February 23, 2024 10:33
ByteOtter
ByteOtter requested changes Feb 23, 2024
View reviewed changes
Copy link
@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just smaller nitpicks, most of which can be disregarded. Otherwise it looks good.

@SchoolGuy @m-czernek
Docs: Add content to the DHCP & DNS pages
6f49538 
Co-authored-by: Marek Czernek <marek.czernek@suse.com>
Co-authored-by: Christopher Hock <christopher.hock@suse.com>
@SchoolGuy SchoolGuy force-pushed the backport/fixup-smaller-docs-issues branch from 81e5b57 to 6f49538 Compare February 23, 2024 11:01
@SchoolGuy SchoolGuy requested a review from ByteOtter February 23, 2024 11:06
@SchoolGuy SchoolGuy linked an issue Feb 23, 2024 that may be closed by this pull request
[Backport] Docs: Fixup smaller issues #3612
Closed
3 tasks
ByteOtter
ByteOtter approved these changes Feb 23, 2024
View reviewed changes
Copy link
@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@SchoolGuy SchoolGuy merged commit 568b5d7 into release33 Feb 23, 2024
@SchoolGuy SchoolGuy deleted the backport/fixup-smaller-docs-issues branch February 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteOtter ByteOtter ByteOtter approved these changes

Assignees
No one assigned
Labels
backport Backported changes and features. documentation Improvements or additions to documentation
Projects
Cobbler Server
Status: Done
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

[Backport] Docs: Fixup smaller issues
2 participants
@SchoolGuy @ByteOtter
0