8000 Rewrite Cobbler packaging by Conan-Kudo · Pull Request #2220 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rewrite Cobbler packaging #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 26, 2019
Merged

Rewrite Cobbler packaging #2220

merged 6 commits into from
Dec 26, 2019

Conversation

Conan-Kudo
Copy link
Member
@Conan-Kudo Conan-Kudo commented Dec 19, 2019 •
edited
Loading

This pull request rewrites the Cobbler packaging into something that supports the full range of distributions that Cobbler is intended to support.

As part of this, the old Debian packaging that has been unmaintained for ~2 years has been dropped and the Debian support has been merged into the cobbler spec file.

Some other fixes have been made as separate commits to fix support for building and running Cobbler everywhere, too.

You can see a build of the spec on OBS here: https://build.opensuse.org/package/show/home:Pharaoh_Atem:cobbler-dev/cobbler

@Conan-Kudo Conan-Kudo force-pushed the rewrite-packaging branch 4 times, most recently from e8be5e4 to ab55300 Compare December 19, 2019 19:31
@Conan-Kudo Conan-Kudo mentioned this pull request Dec 19, 2019
Closed
@Conan-Kudo Conan-Kudo force-pushed the rewrite-packaging branch 2 times, most recently from c59faf0 to e69d21d Compare December 19, 2019 20:36
SchoolGuy
SchoolGuy approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking wonderful. Travis is still broken. I will look at that probably Sunday.

@SchoolGuy
Copy link
Member

@brejoc @watologo1 If you are fine with it I would like one of you two to hit the merge button. Of some else has concerns please speak up!

@SchoolGuy SchoolGuy self-assigned this Dec 26, 2019
SchoolGuy
SchoolGuy reviewed Dec 26, 2019
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of the default tftpboot is the reason for travis to fail because apparently this is not recognized in the setup.py corrently.

@SchoolGuy
Copy link
Member

P.S.: Gitter seems to be down atm...

@SchoolGuy
Copy link
Member

@Conan-Kudo This is your PR so your choice. Either we let the default as it was before or we manipulate the config for the Tests so it is as it was the default before.

@Conan-Kudo
Copy link
Member Author

@SchoolGuy I'm manipulating the config in the tests.

@SchoolGuy
Copy link
Member

@Conan-Kudo I will have a look tomorrow. Now it's bedtime for me... Christmas with the parents is exhausting... (Probably the food but anyway...)

@Conan-Kudo
Set the default tftpboot location to /var/lib/tftpboot
a9c1087 
The location /var/lib/tftpboot is used in all distribution families
except for SUSE distributions. Thus, the standard location should
be the generally accepted one, and the SUSE distributions will get
and override in the spec.
@Conan-Kudo
Switch to xorrisofs as consistent mkisofs implementation
317f1a2 
The Debian/Ubuntu family no longer has a package representing
mkisofs, and the default implementations of mkisofs between RH/Fedora
and SUSE distributions varied far too much.

Instead of allowing this insanity to continue, we're going to just
force using xorrisofs as the mkisofs implementation everywhere.

This at least makes the ISO creation behaviors consistent, making
life easier for everybody, and makes it possible for Cobbler servers
on distributions without a mkisofs provider to function.
@Conan-Kudo
setup.py: Fix webroot path for Debian systems
d826534 
Debian-based systems don't use /srv at all.
@Conan-Kudo
Fix installation of bash completion file
074fb48 
The file was getting installed into the completely useless path of:
 /usr/share/bash-completion/completions/cobbler/cobbler.completion

This made the completion functionally useless. This change ensures
it is installed as /usr/share/bash-completion/completions/cobbler.
@Conan-Kudo
Initial rewrite of Cobbler spec file
ea487f7 
This spec file is loosely based on the packaging shipped in Fedora
and EPEL, but adds portability for SUSE distributions and Debian/Ubuntu
using debbuild.
@Conan-Kudo
Copy link
Member Author

@SchoolGuy The tests pass, so you can merge now.

@SchoolGuy SchoolGuy merged commit c46abca into cobbler:master Dec 26, 2019
@Conan-Kudo Conan-Kudo deleted the rewrite-packaging branch December 26, 2019 21:52
@hbokh
Copy link
Contributor
hbokh commented Jan 14, 2020 •
edited
Loading

@Conan-Kudo The Debian_10 packages v3.1.0 (cobbler and cobbler-web) won’t install on Debian Buster. Multiple errors, for example in the systemd service script (path to cobblerd), sed on the secret key, etc.
Do you want me to file a bug report? Or are they still considered NSFW? 😁

@SchoolGuy
Copy link
Member

@hbokh Please file a bug. Then I can fix it. I am just preparing a PR for fixing the linter...

@Conan-Kudo
Copy link
Member Author
Conan-Kudo commented Jan 14, 2020 •
edited
Loading

@hbokh bug reports welcome. I only made sure it built and the files looked sane. Code fixes are likely still required.

@hbokh
Copy link
Contributor
hbokh commented Jan 14, 2020

Done! See #2238

@SchoolGuy SchoolGuy added this to the v3.1.0 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees

@SchoolGuy SchoolGuy

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Conan-Kudo @SchoolGuy @hbokh
0