8000 Shebang by kwizart · Pull Request #2131 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Shebang #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2019
Merged

Shebang #2131

merged 3 commits into from
Sep 4, 2019

Conversation

kwizart
Copy link
Contributor
@kwizart kwizart commented Aug 30, 2019

Few fixes for shebangs and an empty file.

@SchoolGuy
Copy link
Member

Cool that you found this! I personally have nothing against the /usr/bin/env python3 but there are certainly people like the opensuse build service package maintainers which are not happy about this. They prefer to have it like this: /usr/bin/python3. I will check with them asap and then decide which way we go.

@kwizart
Copy link
Contributor Author
kwizart commented Sep 3, 2019

Thx, the Fedora (EPEL) guideline only mention env to the fix for un-versionned python issue.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Multiple_Python_Runtimes

So the main issue here is to have python3 instead of python. But I can change to /usr/bin/python3 if prefered.

@SchoolGuy
Copy link
Member

That would be indeed preferred at least for the opensuse build service. And since /usr/bin/python3 is a pretty common shebang I would love to see if we use this one.

@kwizart
Switch to python3 shebang
afd5d01 
According to pep-394 python3 should be used insted of python
@kwizart
Remove empty file
0c877fe
@kwizart
fixup shebang for bash
0fd98ad
@kwizart
Copy link
Contributor Author
kwizart commented Sep 4, 2019

forced-pushed with the /usr/bin/python3 shebang

SchoolGuy
SchoolGuy approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very pleased with these changes.

@SchoolGuy SchoolGuy merged commit b6617e4 into cobbler:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwizart @SchoolGuy
0