8000 Fix trigger stacktraces in cobbler.log by SchoolGuy · Pull Request #2953 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix trigger stacktraces in cobbler.log #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix trigger stacktraces in cobbler.log #2953

merged 1 commit into from
Feb 28, 2022

Conversation

SchoolGuy
Copy link
Member

The glob to the triggers was wrong. After fixing this the stacktraces
disappeared and triggers now behave for files and packages as
expected.

Typo fix for utils.run_triggers() is included for this change

@SchoolGuy
Fix trigger stacktraces in cobbler.log
64cfa3c 
The glob to the triggers was wrong. After fixing this the stacktraces
disappeared and triggers now behave for files and packages as
expected.

Typo fix for utils.run_triggers() is included for this change
@SchoolGuy SchoolGuy added this to the v3.3.2 milestone Feb 28, 2022
@SchoolGuy SchoolGuy requested a review from a team February 28, 2022 10:32
@codecov
Copy link
codecov bot commented Feb 28, 2022

Codecov Report

Merging #2953 (64cfa3c) into master (697f5bb) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2953   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files         101      101           
  Lines       14447    14447           
=======================================
  Hits         6764     6764           
  Misses       7683     7683
Impacted Files Coverage Δ
cobbler/cobbler_collections/files.py 39.39% <0.00%> (ø)
cobbler/cobbler_collections/packages.py 40.62% <0.00%> (ø)
cobbler/utils.py 70.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697f5bb...64cfa3c. Read the comment docs.

@SchoolGuy SchoolGuy merged commit 1491cf4 into master Feb 28, 2022
@SchoolGuy SchoolGuy deleted the fix/trigger-log-errors branch February 28, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhestkov vzhestkov vzhestkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @vzhestkov
0