8000 Update DHCP conf for iPXE by SchoolGuy · Pull Request #2944 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update DHCP conf for iPXE #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 5, 2022
Merged

Update DHCP conf for iPXE #2944

merged 16 commits into from
Mar 5, 2022

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented Feb 17, 2022 •
edited
Loading

Fixes #2689

This PR aims to fix the following: Add updated to the DHCP config files on modifications of the enable_ipxe switch.

@SchoolGuy SchoolGuy force-pushed the feature/update-dhcpd-conf-on-ipxe-switch branch 7 times, most recently from 7dba8f2 to a337002 Compare February 28, 2022 15:31
@codecov
Copy link
codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #2944 (4b1d0a0) into master (db70a96) will increase coverage by 0.40%.
The diff coverage is 93.33%.

❗ Current head 4b1d0a0 differs from pull request most recent head b5c7f72. Consider uploading reports for the commit b5c7f72 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
+ Coverage   47.38%   47.79%   +0.40%     
==========================================
  Files         101      101              
  Lines       14404    14412       +8     
==========================================
+ Hits         6826     6888      +62     
+ Misses       7578     7524      -54
Impacted Files Coverage Δ
cobbler/items/system.py 75.17% <ø> (ø)
cobbler/utils.py 71.19% <66.66%> (+0.33%) ⬆️
cobbler/api.py 51.13% <100.00%> (+0.25%) ⬆️
cobbler/cobbler_collections/collection.py 60.88% <100.00%> (+0.35%) ⬆️
cobbler/manager.py 85.71% <100.00%> (ø)
cobbler/modules/managers/isc.py 47.27% <100.00%> (+0.48%) ⬆️
cobbler/actions/mkloaders.py 83.80% <0.00%> (-0.96%) ⬇️
cobbler/actions/sync.py 54.28% <0.00%> (+11.02%) ⬆️
cobbler/modules/managers/in_tftpd.py 57.89% <0.00%> (+11.57%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db70a96...b5c7f72. Read the comment docs.

@SchoolGuy SchoolGuy force-pushed the feature/update-dhcpd-conf-on-ipxe-switch branch 4 times, most recently from 8d5ed64 to 01f763d Compare March 3, 2022 13:37
@SchoolGuy SchoolGuy marked this pull request as ready for review March 4, 2022 10:04
@SchoolGuy SchoolGuy requested a review from a team March 4, 2022 10:04
@SchoolGuy SchoolGuy added the tests label Mar 4, 2022
tiltingpenguin
tiltingpenguin reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor
@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo in commit message Enable more frequent updated of dhcpd.conf: updated -> updates

@SchoolGuy SchoolGuy force-pushed the feature/update-dhcpd-conf-on-ipxe-switch branch from 9ac97c5 to b5c7f72 Compare March 4, 2022 14:27
vzhestkov
vzhestkov approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@SchoolGuy SchoolGuy merged commit 72d8927 into master Mar 5, 2022
@SchoolGuy SchoolGuy deleted the feature/update-dhcpd-conf-on-ipxe-switch branch March 5, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiltingpenguin tiltingpenguin tiltingpenguin left review comments

@vzhestkov vzhestkov vzhestkov approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Trigger /etc/dhcpd.conf update when changing iPXE attribute
3 participants
@SchoolGuy @vzhestkov @tiltingpenguin
0