8000 CI: Add podman support by SchoolGuy · Pull Request #2934 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI: Add podman support #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2022
Merged

CI: Add podman support #2934

merged 3 commits into from
Feb 28, 2022

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented Feb 10, 2022 •
edited
Loading

This PR adds Podman support to our build scripts

@SchoolGuy SchoolGuy added this to the v3.3.1 milestone Feb 10, 2022
@codecov
Copy link
codecov bot commented Feb 10, 2022 •
edited
Loading

Codecov Report

Merging #2934 (58163f8) into master (f96c429) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2934   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files         101      101           
  Lines       14445    14445           
=======================================
  Hits         6763     6763           
  Misses       7682     7682

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96c429...58163f8. Read the comment docs.

@SchoolGuy SchoolGuy force-pushed the feature/add-podman-support branch 2 times, most recently from 01e98bd to abd5d27 Compare February 10, 2022 14:38
@SchoolGuy
Copy link
Member Author

Okay. This is very weird. Locally I did not run into the problems on Debian. I will try to check what possible issues I may have produced.

@SchoolGuy SchoolGuy force-pushed the feature/add-podman-support branch 3 times, most recently from c3996b4 to b21fe74 Compare February 11, 2022 12:54
@SchoolGuy SchoolGuy modified the milestones: v3.3.1, v3.3.2 Feb 21, 2022
@SchoolGuy SchoolGuy force-pushed the feature/add-podman-support branch from b21fe74 to 58163f8 Compare February 22, 2022 07:43
@SchoolGuy SchoolGuy requested a review from nodeg February 22, 2022 07:50
@SchoolGuy SchoolGuy changed the title CI fixes CI: Add podman support Feb 22, 2022
@SchoolGuy SchoolGuy requested review from a team and removed request for nodeg February 22, 2022 08:00
meaksh
meaksh approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member
@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@SchoolGuy SchoolGuy merged commit 60a708b into master Feb 28, 2022
@SchoolGuy SchoolGuy deleted the feature/add-podman-support branch February 28, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meaksh meaksh meaksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @meaksh
0