8000 Enums: Fix failure to convert <<inherit>> by SchoolGuy · Pull Request #2920 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enums: Fix failure to convert <<inherit>> #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

Enums: Fix failure to convert <<inherit>> #2920

merged 1 commit into from
Jan 28, 2022

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented Jan 28, 2022 •
edited
Loading

This also fixes a typo in the VirtDiskDrivers value for INHERITED.

This is a followup (and fixup) for #2901

This should fix #2912

8000
@SchoolGuy
Enums: Fix failure to convert <<inherit>>
8b8eff8 
This also fixes a typo in the VirtDiskDrivers value for INHERITED.
@SchoolGuy SchoolGuy added the main Not a release but referring to the Git main branch label Jan 28, 2022
@SchoolGuy SchoolGuy added this to the v3.3.1 milestone Jan 28, 2022
@SchoolGuy SchoolGuy requested a review from agraul January 28, 2022 11:08
agraul
agraul approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor
@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. It would have been nice to handle the error in the same except KeyError block but since we want a separate error message, this way is better.

@SchoolGuy SchoolGuy merged commit 8487eab into master Jan 28, 2022
@SchoolGuy SchoolGuy deleted the bug/fix-master-enums branch January 28, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agraul agraul agraul approved these changes

Assignees
No one assigned
Labels
main Not a release but referring to the Git main branch
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

regression after enum changes
2 participants
@SchoolGuy @agraul
0