8000 Docs: Explain TFTP and internal database by SchoolGuy · Pull Request #2904 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Docs: Explain TFTP and internal database #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 31, 2022
Merged

Docs: Explain TFTP and internal database #2904

merged 5 commits into from
Jan 31, 2022

Conversation

SchoolGuy
Copy link
Member

@tomschr I would love an informal review as well if time allows. :)

This should clear up some confusion about topics often asked by admins and/or developers.

@SchoolGuy SchoolGuy added this to the v3.3.1 milestone Jan 20, 2022
@SchoolGuy SchoolGuy requested a review from a team January 20, 2022 12:21
@codecov
Copy link
codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #2904 (02e9d93) into master (e53d91d) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 02e9d93 differs from pull request most recent head ef8c54b. Consider uploading reports for the commit ef8c54b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2904      +/-   ##
==========================================
+ Coverage   46.80%   46.83%   +0.03%     
==========================================
  Files         100      101       +1     
  Lines       14434    14462      +28     
==========================================
+ Hits         6756     6774      +18     
- Misses       7678     7688      +10
Impacted Files Coverage Δ
...bler/modules/installation/pre_clear_anamon_logs.py 27.27% <0.00%> (-14.40%) ⬇️
cobbler/settings/migrations/V2_8_5.py 57.14% <0.00%> (-14.29%) ⬇️
cobbler/settings/migrations/V3_2_0.py 84.21% <0.00%> (-10.53%) ⬇️
cobbler/items/image.py 77.83% <0.00%> (-6.21%) ⬇️
cobbler/items/resource.py 89.33% <0.00%> (-3.32%) ⬇️
cobbler/items/distro.py 89.70% <0.00%> (-1.30%) ⬇️
cobbler/items/repo.py 84.28% <0.00%> (-0.41%) ⬇️
cobbler/enums.py 100.00% <0.00%> (ø)
cobbler/remote.py 0.00% <0.00%> (ø)
cobbler/modules/installation/post_power.py 36.36% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a5065...ef8c54b. Read the comment docs.

@olafhering
Copy link
Contributor

In case the directories in /srv/tftpboot are really created on demand by cobblerd, they should be removed from the rpm filelist (remove %{tftpboot_dir}/* and related entries from setup.py.
This would be a followup fix.

The included ls output was done without locale C, maybe redo it with env -i /bin/ls -l.

< 8000 path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" />

tomschr
tomschr suggested changes Jan 20, 2022
View reviewed changes
Copy link
Contributor
@tomschr tomschr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchoolGuy: Wow, lots of work and effort you put into that. 👍 Thanks!
I have a couple of suggestions, ideas, and questions. Hope it makes sense. Try to remove "please", please. 🙂

@SchoolGuy SchoolGuy self-assigned this Jan 21, 2022
@SchoolGuy SchoolGuy added the documentation Improvements or additions to documentation label Jan 21, 2022
tomschr
tomschr suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor
@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchoolGuy Good job! Just some ideas, reminders, suggestions etc. Hope it helps.

@SchoolGuy
Copy link
Member Author

I will clean the Git History after the review.

meaksh
meaksh reviewed Jan 27, 2022
View reviewed changes
Copy link
Member
@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Enno, this looks good. I just added two minor comments 👍

@SchoolGuy SchoolGuy requested review from agraul and meaksh January 27, 2022 13:09
SchoolGuy and others added 5 commits January 31, 2022 12:00
@SchoolGuy @tomschr
Docs: Move repository management into own file
c7dee61 
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
@SchoolGuy @tomschr
Docs: Add note about the new CLI
dda8554 
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
@SchoolGuy
Docs: Remove mkgrub.sh mention
f1bd709
@SchoolGuy @tomschr
Docs: Add limitation inside Uyuni
9d44748 
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
@SchoolGuy @tomschr
Docs: Add explanations for TFTP-Directory & DB
ef8c54b 
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
@SchoolGuy SchoolGuy force-pushed the docs/tftproot-explanation branch from f461521 to ef8c54b Compare January 31, 2022 11:00
@SchoolGuy
6DAF Copy link
Member Author

@meaksh @agraul @tomschr Thanks a lot for the reviews and discussions! Git History was cleaned. Thus I will merge this now!

@SchoolGuy SchoolGuy merged commit 55c1032 into master Jan 31, 2022
@SchoolGuy SchoolGuy deleted the docs/tftproot-explanation branch January 31, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomschr tomschr tomschr requested changes

@meaksh meaksh meaksh approved these changes

@agraul agraul Awaiting requested review from agraul

Assignees

@SchoolGuy SchoolGuy

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@SchoolGuy @olafhering @tomschr @meaksh @agraul
0