8000 Fix RHEL / Fedora arches in signatures by xavierba · Pull Request #2895 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix RHEL / Fedora arches in signatures #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 17, 2022
Merged

Fix RHEL / Fedora arches in signatures #2895

merged 6 commits into from
Jan 17, 2022

Conversation

xavierba
Copy link
Contributor

While looking at adding Fedora 35 and RHEL 9 signatures (#2894), I noticed the arches list for older Fedora and RHEL releases are like ly not correct, so here's a try at fixing this. I'm not sure this is 100% correct for RHEL 4, 5 and 6, so please double check I did not got anything wrong.

@SchoolGuy SchoolGuy self-requested a review January 15, 2022 13:26
@SchoolGuy SchoolGuy added this to the v3.3.1 milestone Jan 15, 2022
@SchoolGuy
Copy link
Member

I am no RHEL expert. @sbluhm is it possible for you to help out here please?

@codecov
Copy link
codecov bot commented Jan 15, 2022

Codecov Report

Merging #2895 (07ae54c) into master (eed8cdc) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
- Coverage   46.82%   46.81%   -0.02%     
==========================================
  Files         101      101              
  Lines       14457    14457              
==========================================
- Hits         6770     6768       -2     
- Misses       7687     7689       +2
Impacted Files Coverage Δ
cobbler/settings/migrations/V3_2_0.py 84.21% <0.00%> (-10.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed8cdc...07ae54c. Read the comment docs.

@sbluhm
Copy link
Contributor
sbluhm commented Jan 15, 2022

I am also not an expert. I looked at the CentOS release architectures at https://vault.centos.org/ $releasever/os/${arch}.

CentOS 4 release looks correct. Last CentOS 4 Release also supported alpha. So not sure which level you are looking for.

CentOS 5 and CentOS 6 only seems to support i386 and x86_64

CentOS 7 only supports x86_64

CentOS 8 only supports aarch64, ppc64le and x86_64

There are certainly other SIG builds like arm that are not officially supported. Maybe you can tell me what exactly you are looking for?

@SchoolGuy
Copy link
Member

@sbluhm Just double checking what the changes in this PR look like to you. But I guess when the information we want is available easily I can check myself. Thanks a lot for the summary.

@xavierba
Copy link
Contributor Author
xavierba commented Jan 16, 2022 •
edited
Loading

Looking at CentOS only is probable not enough, as CentOS was building only a subset of RHEL supported arches. What I put in the PR above is was I extracted from the release notes.

Actually, I started by adding Fedora 35 and RHEL9. Then I noticed arches were off for at least some of the Fedora releases, so I checked all primary and secondary arches for each of them. Then I noticed RHEL 7 was incorrect too and I ended up checking all of RHEL releases, including EOL releases.

If that ease things up, I can split the PR in 2 parts: Fedora and supported RHEL releases then EOL RHEL releases.
Changing the arches for RHEL releases that are not supported anymore is probably not very important at this point in time.

SchoolGuy
SchoolGuy approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@SchoolGuy
Copy link
Member

@xavierba It would be great if you could open a PR against the cobbler.github.io repository, so other people can update their signatures when desired. The diff there will be a bit bigger because I hadn't had the time to update them in the last weeks.

@SchoolGuy SchoolGuy merged commit b2e1c8f into cobbler:master Jan 17, 2022
@xavierba
Copy link
Contributor Author

@xavierba It would be great if you could open a PR against the cobbler.github.io repository, so other people can update their signatures when desired. The diff there will be a bit bigger because I hadn't had the time to update them in the last weeks.

Sure, I can do that. What about merging #2894 in master too, so everything can get in in one go, rather than waiting for 3.3.1 ?

@xavierba
Copy link
Contributor Author

Done. cobbler/cobbler.github.io#172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.1
40E7
Development

Successfully merging this pull request may close these issues.
3 participants
@xavierba @SchoolGuy @sbluhm
0