8000 fix: Cannot set property 'file' of image #2877 by cy-lee · Pull Request #2878 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Cannot set property 'file' of image #2877 #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

fix: Cannot set property 'file' of image #2877 #2878

merged 1 commit into from
Jan 20, 2022

Conversation

cy-lee
Copy link
Contributor
@cy-lee cy-lee commented Dec 23, 2021 •
edited by SchoolGuy
Loading

Fixes #2877

@SchoolGuy
Copy link
Member

@cy-lee Thanks for the submission of the fix! If possible for you I would appreciate a test so we can check that the desired functionality is working. If you are not able to add this to your PR, I would still merge it and add it later.

@SchoolGuy SchoolGuy added this to the v3.3.1 milestone Jan 3, 2022
@SchoolGuy SchoolGuy requested review from a team and SchoolGuy January 3, 2022 12:19
@codecov
Copy link
codecov bot commented Jan 3, 2022 •
edited
Loading

Codecov Report

Merging #2878 (a552dbd) into master (eed8cdc) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2878      +/-   ##
==========================================
+ Coverage   46.82%   46.90%   +0.07%     
==========================================
  Files         101      101              
  Lines       14457    14458       +1     
==========================================
+ Hits         6770     6782      +12     
+ Misses       7687     7676      -11
Impacted Files Coverage Δ
cobbler/items/image.py 84.03% <100.00%> (+6.20%) ⬆️
cobbler/settings/migrations/V3_2_0.py 84.21% <0.00%> (-10.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed8cdc...a552dbd. Read the comment docs.

@cy-lee cy-lee force-pushed the fix-image-file-property branch from 920fad4 to a552dbd Compare January 4, 2022 00:45
@cy-lee
Copy link
Contributor Author
cy-lee commented Jan 4, 2022

Hi, I modify the unit-test in commit, please help to review it, thank you.

@SchoolGuy
Copy link
Member

@cy-lee Sorry for taking so long. I was/am out sick. I will merge this once the PR is tested by the CI. Thanks a lot for your contribution!

SchoolGuy
SchoolGuy approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in my eyes. Thanks for the contribution!

< 8000 /p>

@SchoolGuy SchoolGuy requested a review from a team January 18, 2022 08:02
@SchoolGuy SchoolGuy merged commit cafcb65 into cobbler:master Jan 20, 2022
@cy-lee cy-lee deleted the fix-image-file-property branch January 20, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

@agraul agraul agraul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

Cannot set property 'file' of image
3 participants
@cy-lee @SchoolGuy @agraul
0