8000 Also disable ONBOOT if it is enclosed in quotation marks. by jadiunr · Pull Request #2775 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Also disable ONBOOT if it is enclosed in quotation marks. #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

jadiunr
Copy link
Contributor
@jadiunr jadiunr commented Sep 3, 2021

Some of the ifcfg generated by Anaconda may be enclosed in quotation marks.
The quotes will not match the sed in post_install_network_config when disabling ONBOOT for all interfaces.
In this PR will fix it so that ONBOOT is disabled with or without quotes.

@codecov
Copy link
codecov bot commented Sep 3, 2021

Codecov Report

Merging #2775 (1901d73) into master (af118f5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
- Coverage   43.12%   43.09%   -0.03%     
==========================================
  Files          97       97              
  Lines       14079    14079              
==========================================
- Hits         6071     6067       -4     
- Misses       8008     8012       +4     
Impacted Files Coverage Δ
cobbler/settings/migrations/V3_1_1.py 80.00% <0.00%> (-13.34%) ⬇️
cobbler/settings/migrations/V3_0_0.py 90.00% <0.00%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af118f5...1901d73. Read the comment docs.

@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Sep 6, 2021
@SchoolGuy SchoolGuy self-assigned this Sep 6, 2021
@SchoolGuy SchoolGuy self-requested a review September 6, 2021 07:24
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit ff01d45 into cobbler:master Sep 6, 2021
@jadiunr jadiunr deleted the onboot-disable-when-quoted-value branch August 4, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0