Fix usage of interfacename none if no interfacename is given #2683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On it. |
|
Yes, works for me. |
Codecov Report
@@ Coverage Diff @@
## master #2683 +/- ##
=======================================
Coverage 39.22% 39.22%
=======================================
Files 86 86
Lines 13363 13363
=======================================
Hits 5242 5242
Misses 8121 8121
Continue to review full report at Codecov.
|
|
Now waiting for the quality gatekeeper of our code @nodeg :) |
|
The reporter confirmed that this fix is working for him and requested that this may be merged. Thus not waiting for the review from @nodeg . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2681
@heroin-moose could you please confirm that this fixes the problem you discovered?