8000 Fix arch comparison by heroin-moose · Pull Request #2682 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix arch comparison #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Fix arch comparison #2682

merged 1 commit into from
Jun 23, 2021

Conversation

heroin-moose
Copy link
Contributor

The Enum class does not support string operations like startswith(), but
TFTP code still checks the CPU arch this way. Rewrite the check.

Fixes #2678.

The Enum class does not support string operations like startswith(), but
TFTP code still checks the CPU arch this way. Rewrite the check.

Fixes cobbler#2678.
@nodeg nodeg added the main Not a release but referring to the Git main branch label Jun 23, 2021
@nodeg nodeg added this to the v3.3.0 milestone Jun 23, 2021
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in my eyes. We only have one ARM arch currently in Cobbler, thus no additional arches required.

Copy link
Member
@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this but it seems legit. Thanks @heroin-moose

8000

@SchoolGuy SchoolGuy merged commit 998e3f5 into cobbler:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main Not a release but referring to the Git main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot enable PXE menu for a profile
3 participants
0