8000 Extend the find_items method and test it by SchoolGuy · Pull Request #2663 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extend the find_items method and test it #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

Extend the find_items method and test it #2663

merged 1 commit into from
Jun 9, 2021

Conversation

SchoolGuy
Copy link
Member

This is a splitout #2433

This PR tries to extend the find_items method, so it can be called with no what arg and only a name. Vague tests are included in this PR.

@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Jun 9, 2021
@SchoolGuy SchoolGuy requested a review from nodeg June 9, 2021 10:55
@codecov
Copy link
codecov bot commented Jun 9, 2021

Codecov Report

Merging #2663 (d5aba81) into master (86fad29) will increase coverage by 0.27%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2663      +/-   ##
==========================================
+ Coverage   33.20%   33.48%   +0.27%     
==========================================
  Files          85       85              
  Lines       12395    12410      +15     
==========================================
+ Hits         4116     4155      +39     
+ Misses       8279     8255      -24
Impacted Files Coverage Δ
cobbler/cobbler_collections/manager.py 85.14% <0.00%> (+14.85%) ⬆️
cobbler/remote.py 19.54% <20.00%> (-0.08%) ⬇️
cobbler/api.py 45.60% <80.00%> (+3.37%) ⬆️
cobbler/cobbler_collections/collection.py 40.15% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fad29...d5aba81. Read the comment docs.

nodeg
nodeg approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member
@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodeg nodeg merged commit 9938eb0 into master Jun 9, 2021
@SchoolGuy SchoolGuy deleted the find-items-without-what branch June 9, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodeg nodeg nodeg approved these changes

Assignees

@nodeg nodeg

Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @nodeg
0