10000 Moved from the collection_mgr to the api by SchoolGuy · Pull Request #2652 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Moved from the collection_mgr to the api #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

Moved from the collection_mgr to the api #2652

merged 1 commit into from
May 28, 2021

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented May 28, 2021 •
edited
Loading

The collection mgr is more often used to access the API then the collection_mgr itself. Thus I changed this. Some lines are shorter and we have more control over the data flowing inside Cobbler.

@SchoolGuy SchoolGuy added this to the v3.3.0 milestone May 28, 2021
@SchoolGuy SchoolGuy requested a review from nodeg May 28, 2021 11:38
@SchoolGuy
Copy link
Member Author

Codacy is right about these things but we will ignore it because they will automatically be fixed when PR #2433 is merged. This is preliminary work for the mentioned PR.

@SchoolGuy SchoolGuy force-pushed the collection-mgr-to-api branch from 55ce7e8 to 03f346b Compare May 28, 2021 12:43
@SchoolGuy SchoolGuy force-pushed the collection-mgr-to-api branch from 03f346b to 110d6bb Compare May 28, 2021 13:36
@codecov
Copy link
codecov bot commented May 28, 2021

Codecov Report

Merging #2652 (110d6bb) into master (2c47462) will increase coverage by 0.00%.
The diff coverage is 20.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2652   +/-   ##
=======================================
  Coverage   27.53%   27.53%           
=======================================
  Files          86       86           
  Lines       12418    12425    +7     
=======================================
+ Hits         3419     3421    +2     
- Misses       8999     9004    +5
Impacted Files Coverage Δ
cobbler/remote.py 19.62% <0.00%> (ø)
cobbler/items/system.py 21.85% <9.09%> (ø)
cobbler/cobbler_collections/distros.py 25.00% <11.11%> (ø)
cobbler/cobbler_collections/profiles.py 28.26% <11.11%> (ø)
cobbler/cobbler_collections/images.py 29.54% <12.50%> (ø)
cobbler/cobbler_collections/menus.py 28.26% <12.50%> (ø)
cobbler/cobbler_collections/systems.py 36.11% <16.66%> (ø)
cobbler/cobbler_collections/files.py 39.39% <20.00%> (ø)
cobbler/cobbler_collections/mgmtclasses.py 39.39% <20.00%> (ø)
cobbler/cobbler_collections/packages.py 39.39% <20.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c47462...110d6bb. Read the comment docs.

nodeg
nodeg approved these changes May 28, 2021
View reviewed changes
Copy link
Member
@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodeg nodeg merged commit 19b9d1c into master May 28, 2021
@SchoolGuy SchoolGuy deleted the collection-mgr-to-api branch May 28, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodeg nodeg nodeg approved these changes

Assignees

@nodeg nodeg

Labels
tech-debt
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @nodeg
0