Move first argument of kopts_overwrite to the end and make it optional #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
213e462 to
ca49191
Compare
nodeg
approved these changes
May 28, 2021
There was a problem hiding this comment.
LGTM, although the tests see it otherway.
We have to fix the system.name issue before merging.
[Thread-2874] 2021-05-28T12:10:57 - INFO | Writing template files for testdistro0
[Thread-2874] 2021-05-28T12:10:57 - INFO | Exception occurred: <class 'AttributeError'>
[Thread-2874] 2021-05-28T12:10:57 - INFO | Exception value: 'NoneType' object has no attribute 'name'
[Thread-2874] 2021-05-28T12:10:57 - INFO | Exception Info:
File "/usr/lib/python3.6/site-packages/cobbler/remote.py", line 3645, in _dispatch
return method_handle(*params)
File "/usr/lib/python3.6/site-packages/cobbler/remote.py", line 1995, in save_distro
return self.save_item("distro", object_id, token, editmode=editmode)
File "/usr/lib/python3.6/site-packages/cobbler/remote.py", line 1982, in save_item
self.api.add_item(what, obj)
File "/usr/lib/python3.6/site-packages/cobbler/api.py", line 750, in add_item
self.get_items(what).add(ref, check_for_duplicate_names=check_for_duplicate_names, save=save)
File "/usr/lib/python3.6/site-packages/cobbler/cobbler_collections/collection.py", line 403, in add
self.lite_sync.add_single_distro(ref.name)
File "/usr/lib/python3.6/site-packages/cobbler/actions/sync.py", line 336, in add_single_distro
self.tftpgen.make_pxe_menu()
File "/usr/lib/python3.6/site-packages/cobbler/tftpgen.py", line 312, in make_pxe_menu
metadata = self.get_menu_items()
File "/usr/lib/python3.6/site-packages/cobbler/tftpgen.py", line 359, in get_menu_items
return self.get_menu_level(None, arch)
File "/usr/lib/python3.6/site-packages/cobbler/tftpgen.py", line 536, in get_menu_level
self.get_profiles_menu(menu, metadata, arch)
File "/usr/lib/python3.6/site-packages/cobbler/tftpgen.py", line 436, in get_profiles_menu
image=None, format=boot_loader)
File "/usr/lib/python3.6/site-packages/cobbler/tftpgen.py", line 664, in write_pxe_file
image, arch, metadata["autoinstall"])
File "/usr/lib/python3.6/site-packages/cobbler/tftpgen.py", line 843, in build_kernel_options
utils.kopts_overwrite(distro, kopts, self.settings, system.name)ca49191 to
d15f920
Compare
|
This method was now converted to "I am paranoid and mentally ill" way of running. |
|
That looks much better now. So the typechecking is indeed important and improves the overall code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this because passing the whole object is not desired since we only need the name I changed the method signature.