8000 Fix settings file for 'cobbler check' by wica128 · Pull Request #2630 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix settings file for 'cobbler check' #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

Fix settings file for 'cobbler check' #2630

merged 1 commit into from
May 10, 2021

Conversation

wica128
Copy link
Contributor
@wica128 wica128 commented May 8, 2021

When using cobbler check it will complain about settings in /etc/cobbler/settings instead of /etc/cobbler/settings.yaml

SchoolGuy
SchoolGuy approved these changes May 8, 2021
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy requested a review from nodeg May 8, 2021 18:41
@SchoolGuy SchoolGuy self-assigned this May 8, 2021
@SchoolGuy SchoolGuy added main Not a release but referring to the Git main branch Usability labels May 8, 2021
@SchoolGuy SchoolGuy added this to the v3.3.0 milestone May 8, 2021
nodeg
nodeg approved these changes May 10, 2021
View reviewed changes
Copy link
Member
@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the line length is too long. But this will be done with some of our cleanup PRs in the near future.
@wica128 Thank you for your contribution!

@codecov
Copy link
codecov bot commented May 10, 2021

Codecov Report

Merging #2630 (fb61b09) into master (c7fc767) will decrease coverage by 1.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   29.38%   27.79%   -1.59%     
==========================================
  Files          93       86       -7     
  Lines       12898    12278     -620     
==========================================
- Hits         3790     3413     -377     
+ Misses       9108     8865     -243
Impacted Files Coverage Δ
cobbler/actions/check.py 13.02% <ø> (+0.12%) ⬆️
cobbler/items/image.py 30.08% <0.00%> (-5.72%) ⬇️
cobbler/items/profile.py 31.87% <0.00%> (-4.22%) ⬇️
cobbler/settings.py 72.09% <0.00%> (-3.36%) ⬇️
cobbler/modules/sync_post_wingen.py 10.04% <0.00%> (-2.71%) ⬇️
cobbler/items/distro.py 32.33% <0.00%> (-2.38%) ⬇️
cobbler/cobbler_collections/systems.py 36.11% <0.00%> (-1.73%) ⬇️
cobbler/cobbler_collections/images.py 29.54% <0.00%> (-1.57%) ⬇️
cobbler/cobbler_collections/profiles.py 28.26% <0.00%> (-1.53%) ⬇️
cobbler/cobbler_collections/collection.py 20.53% <0.00%> (-1.39%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7fc767...fb61b09. Read the comment docs.

@SchoolGuy SchoolGuy merged commit 1eb236a into cobbler:master May 10, 2021
@wica128 wica128 deleted the fix_config_file_in_check branch May 14, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodeg nodeg nodeg approved these changes

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees

@SchoolGuy SchoolGuy

Labels
main Not a release but referring to the Git main branch Usability
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wica128 @nodeg @SchoolGuy
0