8000 Remove get-loaders code by nodeg · Pull Request #2572 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove get-loaders code #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2021
Merged

Remove get-loaders code #2572

merged 1 commit into from
Mar 6, 2021

Conversation

nodeg
Copy link
Member
@nodeg nodeg commented Mar 5, 2021

This PR removes the old get-loaders code from Cobbler. It is not very safe to download bootloaders from unknown sources.

@nodeg nodeg added this to the v3.3.0 milestone Mar 5, 2021
@nodeg nodeg requested a review from SchoolGuy March 5, 2021 15:30
@SchoolGuy SchoolGuy self-assigned this Mar 5, 2021
@codecov
Copy link
codecov bot commented Mar 5, 2021

Codecov Report

Merging #2572 (27f6b97) into master (62ca3bd) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2572      +/-   ##
==========================================
- Coverage   29.32%   29.31%   -0.02%     
==========================================
  Files          92       91       -1     
  Lines       12864    12831      -33     
==========================================
- Hits         3773     3761      -12     
+ Misses       9091     9070      -21
Impacted Files Coverage Δ
cobbler/actions/check.py 12.90% <0.00%> (ø)
cobbler/cli.py 62.15% <ø> (-0.28%) ⬇️
cobbler/remote.py 19.21% <ø> (-0.02%) ⬇️
cobbler/api.py 36.19% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ca3bd...27f6b97. Read the comment docs.

SchoolGuy
SchoolGuy approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in my eyes

watologo1
watologo1 approved these changes Mar 6, 2021
View reviewed changes
Copy link
Contributor
@watologo1 watologo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Bootloaders definitely should not get downloaded without any checks from static sites.

@SchoolGuy SchoolGuy merged commit 636d875 into cobbler:master Mar 6, 2021
@nodeg nodeg deleted the remove_get_loaders branch March 6, 2021 17:11
@nodeg nodeg mentioned this pull request Mar 8, 2021
Closed
@nodeg nodeg mentioned this pull request Jun 8, 2021
Closed
@SchoolGuy SchoolGuy mentioned this pull request Apr 3, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watologo1 watologo1 watologo1 approved these changes

@SchoolGuy SchoolGuy SchoolGuy approved these changes

@hbokh hbokh Awaiting requested review from hbokh

@brejoc brejoc Awaiting requested review from brejoc

@Conan-Kudo Conan-Kudo Awaiting requested review from Conan-Kudo

@dansou901 dansou901 Awaiting requested review from dansou901

Assignees

@SchoolGuy SchoolGuy

Labels
Security tech-debt
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nodeg @watologo1 @SchoolGuy
0